-
Notifications
You must be signed in to change notification settings - Fork 183
[help] fix the help widget extending over the height of a page #9105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@shonibare can you provide screenshots of the before and after ? |
@shonibare I still see it extending in width past the size of the page as described in the issue |
Fixed @ridz1208 ![]() |
@skarya22 change your first name last name to very short values (i.e. Rida test instead of Admin account) and you will get the horizontal issue |
htdocs/main.css
Outdated
@@ -684,11 +684,12 @@ tr.directentry { | |||
border-top: none; | |||
border-width: 1px; | |||
position: absolute; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
position: absolute; | |
position: fixed; | |
right: 0; |
I think this would be a better solution as it works irrelevant of how long the name is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it still works on my screen, updated the changes. I hope the help widget is positioned same place on your screen compared to your previous screenshot? @skarya22
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the changes I could see it aligned with the right side of the screen no matter the name length! Thank you for updating with the changes requested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
issue #9087
This PR fixes the help widget height extending over a page