Fixes links to BrainBrowser from the MRI violations module #8392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmadjar
added
Category: Bug
driusan
approved these changes
Feb 20, 2023
Collaborator
driusan
left a comment
driusan
left a comment
There was a problem hiding this comment.
I think the branch is broken but I'll merge it once it's fixed.
cmadjar
force-pushed
the
fixes_links_in_BB_not_opening_the_right_file
branch
from
40ec3ea to
0bd67b9
Compare
1 task
zaliqarosli
pushed a commit
to zaliqarosli/Loris
that referenced
this pull request
Mar 6, 2023
…dule (aces#8392) The links to BrainBrowser from the MRI violations module were not working for two reasons: - queried the wrong table name for the protocol violations (mri_violations_log should have been used instead of mri_violation_log) - the FileDownloadHandler class was using the basename of the file instead of the relative path which resulted in BrainBrowser not finding the file on the file system. These bugs were found when testing aces#7473 but have been present since 24.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
The links to BrainBrowser from the MRI violations module were not working for two reasons:
mri_violations_logshould have been used instead ofmri_violation_log)FileDownloadHandlerclass was using the basename of the file instead of the relative path which resulted in BrainBrowser not finding the file on the file system.Link(s) to related issue(s)