[SQL] Reorder release patches for 24.0 release #8390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ridz1208
added
the
Critical to release
zaliqarosli
pushed a commit
to zaliqarosli/Loris
that referenced
this pull request
Mar 6, 2023
Extracts one patch from the main release patch file for the 24.0 LORIS release and adds it to a new file to be run ahead of any PHP scripts. this is required as all PHP scripts (even the ones that have to be run before the release patch) depend on these SQL statements causing a circular dependency.
driusan
pushed a commit
that referenced
this pull request
Mar 13, 2023
Since the order in which the patches were run was changed by #8390. The statements in this PR which add the date_format cause a truncation error since they also "remove" the log_level enum option. The patch that is run first now as patch _A already contains the date format and is thus sufficient to replace the statements removed here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
Extracts one patch from the main release patch file for the 24.0 LORIS release and adds it to a new file to be run ahead of any PHP scripts. this is required as all PHP scripts (even the ones that have to be run before the release patch) depend on these SQL statements causing a circular dependency.
Once this is merged and release, Existing major and minor releases should be updated to reflect the changes