Skip to content

Conversation

@laemtl
Copy link
Contributor

@laemtl laemtl commented Jan 13, 2023

Fix a few issues with EEGLAB set/fdt files:

  • Download link broken
  • incorrect placement, it should be logically after the .set file

Download All files fails when no annotations exists.
Migrate the annotation files creation logic from update to updateFiles, since update handles DB updates only.

@laemtl laemtl changed the title [EEG Browser] EEGLAB fdt fixes [EEG Browser] EEGLAB fdt / annotations fixes Jan 13, 2023
@laemtl laemtl changed the title [EEG Browser] EEGLAB fdt / annotations fixes [EEG Browser] Fix Download broken links Jan 13, 2023
Copy link
Contributor

@jeffersoncasimir jeffersoncasimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great.

@jeffersoncasimir jeffersoncasimir added the Passed manual tests PR has been successfully tested by at least one peer label Feb 14, 2023
@driusan driusan merged commit 0114075 into aces:main Feb 14, 2023
@ridz1208 ridz1208 added this to the 25.0.0 milestone Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Passed manual tests PR has been successfully tested by at least one peer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants