[jsx/Panel.js] Improved Panel component with optional multiple views #8299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maltheism
added
Category: Feature
Collaborator
|
The arrows to collapse the panel are not rendering correctly:
Things are looking good other than this! |
CamilleBeau
added
the
State: Needs work
laemtl
removed
the
State: Needs work
laemtl
force-pushed
the
react_panel_multiple_views
branch
from
e100df3 to
4a3fcce
Compare
laemtl
force-pushed
the
react_panel_multiple_views
branch
from
4a3fcce to
ffad66a
Compare
laemtl
force-pushed
the
react_panel_multiple_views
branch
from
ffad66a to
34e711a
Compare
Contributor
|
Ready. I also rebased the PR to get rid of the unrelevant commits. |
laemtl
added
the
State: Needs work
laemtl
removed
the
State: Needs work
Contributor
|
Ready |
Contributor
|
@CamilleBeau Can you retest and approve if this fixes your issue? |
CamilleBeau
approved these changes
Mar 21, 2023
Collaborator
Approved! It's fixed now. Thanks Laetitia! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
Updated the Panel component to handle views if given. Also refactored the code to be a react functional component instead of a class. Used in PR: #8261
Testing instructions (if applicable)