Fix sizing of form elements when there is no label #8196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when the label is empty for some elements, it still includes a col-sm-3 element which offsets the element and no way to suppress it. Other elements do not include the 3 column space for the label when there is no label provided. This causes our elements to look weird and inconsistent when used in places that we just want the element (ie. in a flexbox row.) This fixes the - DateElement - TimeElement - NumericElement - FileElement So that there is no space left for the label if the label is not provided.
driusan
added
Area: UI
maltheism
added
the
Passed manual tests
maltheism
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when the label is empty for some elements, it still includes a col-sm-3 element which offsets the element and no way to suppress it. Other elements do not include the 3 column space for the label when there is no label provided. This causes our elements to look weird and inconsistent when used in places that we just want the element (ie. in a flexbox row.)
This fixes the
So that there is no space left for the label if the label is not provided.