Skip to content

Conversation

@maltheism
Copy link
Member

@maltheism maltheism commented Oct 18, 2022

Brief summary of changes

Upgrades react to version 18 and upgrade to latest rendering of react. See the following:

ReactDOM.render is no longer supported in React 18. Use createRoot instead. Until you switch to the new API, your app will behave as if it's running React 17. Learn more: https://reactjs.org/link/switch-to-createroot

Testing instructions (if applicable)

  1. checkout pr
  2. make clean
  3. make dev

@maltheism maltheism added the Area: Dependencies PR that updates dependency files label Oct 18, 2022
@maltheism maltheism requested review from driusan and laemtl October 18, 2022 16:58
@maltheism maltheism changed the title [package.json] Upgrade react [package.json] Upgrade react to version 18 Oct 18, 2022
@driusan
Copy link
Collaborator

driusan commented Oct 18, 2022

@laemtl should this fix the TS errors/remove the ts-ignore markers?

@laemtl
Copy link
Contributor

laemtl commented Oct 18, 2022

@laemtl should this fix the TS errors/remove the ts-ignore markers?

I'm not sure, the ts-ignore markers are fixing a package incompatibility with React 18 new types.

-- edit
Good news, it turns out that the upgrade might have fixed the incompatibility, so we can remove the @ts-ignore comments. I will test the viz features and confirm.

@maltheism
Copy link
Member Author

Hi @driusan, Laetitia and I are going to test if we can remove the ts-ignore lines tomorrow. Latest commits have some changes concerning it.

@laemtl
Copy link
Contributor

laemtl commented Dec 14, 2022

@maltheism The PR needs a rebase. Otherwise I tested it and it works, thank you so much for your help on this!

@laemtl laemtl added the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Dec 14, 2022
@maltheism maltheism removed the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Dec 20, 2022
@maltheism
Copy link
Member Author

@laemtl ready

@driusan driusan mentioned this pull request Jan 4, 2023
@laemtl laemtl force-pushed the react_upgrade_main branch from 72548c3 to 771a31b Compare February 23, 2023 21:45
@laemtl laemtl force-pushed the react_upgrade_main branch from 75a2a4e to a8b9806 Compare February 24, 2023 06:10
@laemtl laemtl self-requested a review February 24, 2023 06:11
@laemtl laemtl force-pushed the react_upgrade_main branch from a8b9806 to 1fe9442 Compare February 24, 2023 06:19
Copy link
Contributor

@laemtl laemtl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modules/imaging_qc/js/qualityControlIndex.js was deleted. It seems to be a leftover from #5620.

@driusan driusan merged commit 4c967d1 into aces:main Feb 24, 2023
@ridz1208 ridz1208 added this to the 25.0.0 milestone Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Dependencies PR that updates dependency files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants