-
Notifications
You must be signed in to change notification settings - Fork 188
[package.json] Upgrade react to version 18 #8188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@laemtl should this fix the TS errors/remove the ts-ignore markers? |
I'm not sure, the ts-ignore markers are fixing a package incompatibility with React 18 new types. -- edit |
|
Hi @driusan, Laetitia and I are going to test if we can remove the ts-ignore lines tomorrow. Latest commits have some changes concerning it. |
|
@maltheism The PR needs a rebase. Otherwise I tested it and it works, thank you so much for your help on this! |
|
@laemtl ready |
72548c3 to
771a31b
Compare
75a2a4e to
a8b9806
Compare
a8b9806 to
1fe9442
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modules/imaging_qc/js/qualityControlIndex.js was deleted. It seems to be a leftover from #5620.
Brief summary of changes
Upgrades react to version 18 and upgrade to latest rendering of react. See the following:
Testing instructions (if applicable)