Add phase encoding direction and scan options to mri protocol and mri protocol violated scans #8149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@driusan eventually, we will need to modify the mri_violations module to display those new fields. I see that image_type is not in the mri_violations either so I was thinking of sending a different PR to fix this so that at least the MRI side of things work for the insertion. Thoughts? If you agree, then I will create an issue and assign to me. Thanks! |
Add support for the 'file' type in LorisFormDictionaryImpl
- backporting fix for the display of the dictionary in the DQT module aces#7098 - in the data_dictionary_builder script, reference the tesname value in parsed instruments (lorisform parser output format) instead of table while keeping it backwards compatible. This is needed because JSONdata instruments do not define a table variable and since [23.0.3] (https://github.com/aces/Loris/pull/7153/files#diff-962394c093e5275dcfa7cc6eca8927b2f8f592f42b7b95ec5921cb7fc0dc8453R88) the lorisform parser exports the test name in its output for this specific reason.
…email falsifies validity (aces#8137) When an email address is entered with invalid characters, the invalid characters are currently stripped before the address is validated, causing the validation to improperly pass when it should fail for email addresses such as "test@gmail.com>". The sanitation pass turns that into "test@gmail.com" before it's validated, which returns "true" despite the address entered being invalid. This also removes an old check for < > and " because the new check offers a clearer error message and covers a broader range of characters we don't want in emails (because of escaping issues).
…ations (aces#8139) Although this use case should never happen as it is prevented by rules in the edit_user logic, a couple bugs have let it happen in the past and the entire module becomes inaccessible. This makes the module load and displays a message in the user row informing the editor that the user does not currently have any sites and projects. The only way to test this would be to manually delete all site associations directly in the DB user_psc_rel OR all project associations user_project_rel Note that the module crashes even if the user not having any sites or projects is not the editor nor the editee... any user can cause this issue.
cmadjar
force-pushed
the
add_PhaseEncodingDirection_and_ScanOptions_to_mri_protocol_and_mri_protocol_violated_scans
branch
from
01d68b1 to
c8431a0
Compare
Collaborator
Author
|
New PR based out of 24.1-release branch: #8150 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
This adds the columns
PhaseEncodingDirectionsandScanOptionsto themri_protocolandmri_protocol_violated_scanstables so that those headers could be used to discriminate between some MRI sequences.Testing instructions (if applicable)
Link(s) to related issue(s)