Skip to content

[Docs] Update Troubleshooting Documentation for expired lorisadmin account #8102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 6, 2022
Merged

[Docs] Update Troubleshooting Documentation for expired lorisadmin account #8102

merged 9 commits into from
Sep 6, 2022

Conversation

@satvik-tha-god
Copy link
Contributor

@satvik-tha-god satvik-tha-god commented May 31, 2022

Brief summary of changes

  • Updated the Installation troubleshooting guide's admin section
  • Step by step instruction to deal with a deactivated admin account due to inactivity

Link(s) to related issue(s)

@christinerogers christinerogers self-requested a review May 31, 2022 14:08
christinerogers
christinerogers requested changes May 31, 2022
View reviewed changes
Copy link
Contributor

@christinerogers christinerogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @satvik-tha-god and congrats on your first PR 🎉
I've suggested some very minor tweaks related how we document setup/credentials.
Please see my suggestions inline below, and be sure to re-request my review when you've addressed these, and I'll approve.

I saw you committed this to main which is great.
Any thoughts @racostas on whether this should (also) go to the 24 branch, for good practice?

@christinerogers christinerogers added the Category: Documentation PR or issue that aims to improve the documentation label May 31, 2022
satvik-tha-god and others added 4 commits June 1, 2022 13:59
@satvik-tha-god @christinerogers
Update docs/wiki/00_SERVER_INSTALL_AND_CONFIGURATION/01_LORIS_Install…
a377243 
…/Troubleshooting.md

Co-authored-by: christinerogers <christinerogers@users.noreply.github.com>
@satvik-tha-god @christinerogers
Update docs/wiki/00_SERVER_INSTALL_AND_CONFIGURATION/01_LORIS_Install…
aba0565 
…/Troubleshooting.md

Co-authored-by: christinerogers <christinerogers@users.noreply.github.com>
@satvik-tha-god
Update Troubleshooting.md
84066c1
@satvik-tha-god
Merge branch 'aces:main' into main
63b9995
ridz1208
ridz1208 previously approved these changes Jun 1, 2022
View reviewed changes
docs/wiki/00_SERVER_INSTALL_AND_CONFIGURATION/01_LORIS_Install/Troubleshooting.md Outdated
Comment on lines 68 to 72
3. Run the following command:
```
DELETE FROM user_login_history WHERE UserID = "admin";
```
***Note:** Using this command will wipe out your account's login history*
Copy link
Collaborator

@ridz1208 ridz1208 Jun 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might have found a better way a little while ago. I think instead of erasing history, we can manually add an entry like

INSERT INTO user_login_history (userID,Success,Page_requested) VALUE ('admin','Y','/');

This need to be tested but I find it a better alternative to deletion

Copy link
Contributor

@racostas racostas Jun 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @satvik-tha-god. Please let's try @ridz1208 suggestions and if goes well I will do prefer this solution instead of erasing the history of the account, I agree with both @christinerogers and @ridz1208.

Copy link
Contributor Author

@satvik-tha-god satvik-tha-god Jun 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the changes

Copy link
Contributor

@christinerogers christinerogers Jun 1, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, just let us know -- Did you also test it as Rida suggested? what happened to your table?

This need to be tested but I find it a better alternative to deletion

Copy link
Contributor Author

@satvik-tha-god satvik-tha-god Jun 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not being descriptive earlier, I did run the command on my database and everything seems to be working fine

I was able to login normally with no issues after running those commands

@ridz1208 ridz1208 dismissed their stale review June 1, 2022 12:48

mistake

@satvik-tha-god @christinerogers
Update docs/wiki/00_SERVER_INSTALL_AND_CONFIGURATION/01_LORIS_Install…
57541ca 
…/Troubleshooting.md

Co-authored-by: christinerogers <christinerogers@users.noreply.github.com>
christinerogers
christinerogers approved these changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@christinerogers christinerogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks for the changes @satvik-tha-god - this PR looks good to me.
@racostas - over to you to pull, test and review?

@christinerogers christinerogers requested a review from racostas June 6, 2022 18:20
@racostas racostas self-requested a review June 8, 2022 15:14
racostas
racostas requested changes Jun 8, 2022
View reviewed changes
@satvik-tha-god @racostas
Update docs/wiki/00_SERVER_INSTALL_AND_CONFIGURATION/01_LORIS_Install…
2d348fd 
…/Troubleshooting.md

Co-authored-by: racostas <37309344+racostas@users.noreply.github.com>
racostas
racostas approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@racostas racostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@racostas
Copy link
Contributor

racostas commented Jun 9, 2022

@driusan, Please take a last look but I think this one is ready to be merged.

@racostas racostas added the Passed manual tests PR has been successfully tested by at least one peer label Jul 19, 2022
@christinerogers
Copy link
Contributor

christinerogers commented Aug 31, 2022

Hi @driusan @ridz1208 - I think this should be a quick merge, it was a documentation update requested by users, and it's had 2 approvals since June.
Could you help us out as Satvik wraps up his GSOC period with us? thanks -
cc @satvik-tha-god @racostas

@christinerogers
Copy link
Contributor

christinerogers commented Sep 1, 2022

Thanks @ridz1208 --

@driusan over to you for the last review before merging.

Note @racostas is away next week so your help with all these GSOC PRs is key this week. thanks!

@driusan driusan merged commit 0721c33 into aces:main Sep 6, 2022
@ridz1208 ridz1208 added this to the 25.0.0 milestone Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christinerogers christinerogers christinerogers approved these changes

@ridz1208 ridz1208 ridz1208 approved these changes

@racostas racostas racostas approved these changes

Assignees

No one assigned

Labels

Category: Documentation PR or issue that aims to improve the documentation Passed manual tests PR has been successfully tested by at least one peer

Projects

None yet

Milestone

25.0.0

Development

Successfully merging this pull request may close these issues.

[docs] Add to Markdown docs: step by step how to unlock lorisadmin account

5 participants

@satvik-tha-god @racostas @christinerogers @ridz1208 @driusan