Skip to content

[DB schema] UNIQUE Project name #7566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[DB schema] UNIQUE Project name #7566

wants to merge 3 commits into from

Conversation

@xlecours
Copy link
Contributor

@xlecours xlecours commented Sep 13, 2021 •
edited
Loading

Brief summary of changes

Add a UNIQUE constraint on Project.Name

@xlecours xlecours added Release: Add to release notes PR whose changes should be highlighted in the release notes Release: Breaking changes PR that contains changes that might impact the code or accepted practices of active projects Language: SQL PR or issue that update SQL code State: Needs RB update PR that needs to update Raisinbread to reflect its changes labels Sep 13, 2021
@xlecours xlecours requested a review from laemtl September 13, 2021 16:42
@xlecours xlecours removed the State: Needs RB update PR that needs to update Raisinbread to reflect its changes label Sep 13, 2021
laemtl
laemtl requested changes Sep 15, 2021
View reviewed changes
@laemtl laemtl self-requested a review September 16, 2021 17:43
laemtl
laemtl requested changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@laemtl laemtl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xlecours 2 tests are failing, but not sure if it's related to the DB changes.

@xlecours
Copy link
Contributor Author

xlecours commented Sep 17, 2021

@xlecours 2 tests are failing, but not sure if it's related to the DB changes.

The 2 tests that failed are requesting pages that work just fine on my vm. I restarted the jobs. Let's see...

@driusan
Copy link
Collaborator

driusan commented Sep 20, 2021

@laemtl the tests are passing now, are there changes you wanted?

@cmadjar cmadjar added the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Nov 29, 2022
@xlecours xlecours changed the base branch from main to 24.1-release November 29, 2022 18:00
@xlecours xlecours changed the base branch from 24.1-release to main November 29, 2022 18:00
@xlecours
Copy link
Contributor Author

xlecours commented Nov 29, 2022

@cmadjar why the "Need rebase" tag?

@ridz1208
Copy link
Collaborator

ridz1208 commented Nov 29, 2022 •
edited
Loading

@xlecours some tests are not running

@github-actions
LORIS Test Suite / build (integration, 8) (pull_request) Successful in 37m
[Details](https://github.com/aces/Loris/actions/runs/1238689000/jobs/1505220274)
build (integration, 8.0) Expected — Waiting for status to be reported
Required
build (integration, 8.1) Expected — Waiting for status to be reported
Required
build (static, 8.0) Expected — Waiting for status to be reported
Required
build (static, 8.1) Expected — Waiting for status to be reported
Required
build (unit, 8.0) Expected — Waiting for status to be reported
Required
build (unit, 8.1) Expected — Waiting for status to be reported

@xlecours xlecours closed this Nov 29, 2022
@xlecours xlecours mentioned this pull request Nov 29, 2022
Merged
@xlecours
Copy link
Contributor Author

xlecours commented Nov 29, 2022

Resent in #8243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laemtl laemtl laemtl requested changes

Assignees

@xlecours xlecours

Labels

Language: SQL PR or issue that update SQL code Release: Add to release notes PR whose changes should be highlighted in the release notes Release: Breaking changes PR that contains changes that might impact the code or accepted practices of active projects State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[DB schema] Project name should be UNIQUE

5 participants

@xlecours @driusan @ridz1208 @laemtl @cmadjar