Skip to content

[Publication] jQuery usage cleaning #7283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 18, 2021
Merged

[Publication] jQuery usage cleaning #7283

merged 3 commits into from
Jan 18, 2021

Conversation

@laemtl
Copy link
Contributor

@laemtl laemtl commented Jan 8, 2021 •
edited
Loading

First attempt to clean progressively jQuery from the modules.
Replace $.ajax by fetch and $.ready by document.addEventListener('DOMContentLoaded')

Makes also use of arrow functions to avoid the use of bind(this)

@laemtl laemtl changed the title [Publication] Jquery usage cleaning [Publication] jQuery usage cleaning Jan 8, 2021
@laemtl laemtl force-pushed the 2020-01-08-publication-jquery-usage-clean branch 2 times, most recently from 1dd2247 to 159305c Compare January 9, 2021 01:11
@laemtl laemtl added Category: Cleanup PR or issue introducing/requiring at least one clean-up operation State: Blocked PR or issue awaiting an external event such as the merge or another PR to proceed labels Jan 9, 2021
@laemtl laemtl force-pushed the 2020-01-08-publication-jquery-usage-clean branch from 159305c to 3282bdc Compare January 9, 2021 01:28
maltheism
maltheism requested changes Jan 11, 2021
View reviewed changes
@laemtl laemtl requested a review from maltheism January 11, 2021 20:08
@driusan
Copy link
Collaborator

driusan commented Jan 18, 2021

Seems to have conflicts..

@driusan
Copy link
Collaborator

driusan commented Jan 18, 2021

Skimmed it and it looks good (if long overdue!) but it has conflicts and can't be merged

@laemtl laemtl removed the State: Blocked PR or issue awaiting an external event such as the merge or another PR to proceed label Jan 18, 2021
@laemtl laemtl force-pushed the 2020-01-08-publication-jquery-usage-clean branch from e9f3fcf to 4af0ba4 Compare January 18, 2021 19:21
@laemtl
Copy link
Contributor Author

laemtl commented Jan 18, 2021

@driusan Rebased.

@driusan driusan merged commit 7f5b9c1 into aces:main Jan 18, 2021
@laemtl laemtl mentioned this pull request Feb 2, 2021
Merged
driusan pushed a commit that referenced this pull request Feb 3, 2021
@laemtl
Fetch response status fix (#7317)
4a776e1 
Previous fetch implementations (PR #7293, #7283) were assuming a response status of 200, which will produce problems if the status is in the range [200..299]. Such status still confirms that the request ran successfully.
AlexandraLivadas pushed a commit to AlexandraLivadas/Loris that referenced this pull request Jun 29, 2021
@laemtl @AlexandraLivadas
[Publication] jQuery usage cleaning (aces#7283)
73ed80e 
First attempt to clean progressively jQuery from the modules.
Replace $.ajax by fetch and $.ready by document.addEventListener('DOMContentLoaded') in publication module.
AlexandraLivadas pushed a commit to AlexandraLivadas/Loris that referenced this pull request Jun 29, 2021
@laemtl @AlexandraLivadas
Fetch response status fix (aces#7317)
ecd595c 
Previous fetch implementations (PR aces#7293, aces#7283) were assuming a response status of 200, which will produce problems if the status is in the range [200..299]. Such status still confirms that the request ran successfully.
@ridz1208 ridz1208 added this to the 24.0.0 milestone Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maltheism maltheism maltheism approved these changes

Assignees

No one assigned

Labels

Category: Cleanup PR or issue introducing/requiring at least one clean-up operation

Projects

None yet

Milestone

24.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@laemtl @driusan @maltheism @ridz1208