Skip to content

Conversation

@ridz1208
Copy link
Collaborator

Brief summary of changes

These changes were made to reflect the #6923 which was issued to the main branch

Additional changes not in #6923:

  • modified the "stripping" function to only remove _date if it is positioned at the end of the field name. For example if the user names their date field my_date_of_release_date, previously the function would strip the field name to my; now it would only strip the last _date to become my_date_of_release
  • removed the check for isset($dateformat) since the code is already converting a null $dateformat to an empty string 2 lines above !
  • reorganized the if statements to reduce over all complexity
  • added an exception if the date format does not match any known formats

@ridz1208 ridz1208 force-pushed the linst_date_element_fix branch from 88ed8d6 to b82f63a Compare December 23, 2020 14:54
@ridz1208
Copy link
Collaborator Author

@zaliqarosli could you review

Copy link
Contributor

@zaliqarosli zaliqarosli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ridz1208
Copy link
Collaborator Author

@zaliqarosli do you have time to test it quick quick ?

@zaliqarosli
Copy link
Contributor

@ridz1208 ya on it!

Co-authored-by: Zaliqa <zaliqa.rosli@mcin.ca>
@zaliqarosli zaliqarosli added the Passed manual tests PR has been successfully tested by at least one peer label Dec 23, 2020
@zaliqarosli
Copy link
Contributor

ill re-approve after you fix phpcs!

@driusan driusan merged commit d549725 into aces:23.0-release Dec 23, 2020
@ridz1208 ridz1208 added this to the 23.0.3 milestone Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Passed manual tests PR has been successfully tested by at least one peer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants