-
Notifications
You must be signed in to change notification settings - Fork 188
[LINST] modify LINST class to only strip '_date' from standard dates #7260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
88ed8d6 to
b82f63a
Compare
Collaborator
Author
|
@zaliqarosli could you review |
zaliqarosli
requested changes
Dec 23, 2020
Co-authored-by: Zaliqa <zaliqa.rosli@mcin.ca>
zaliqarosli
approved these changes
Dec 23, 2020
Contributor
zaliqarosli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Collaborator
Author
|
@zaliqarosli do you have time to test it quick quick ? |
Contributor
|
@ridz1208 ya on it! |
zaliqarosli
requested changes
Dec 23, 2020
Co-authored-by: Zaliqa <zaliqa.rosli@mcin.ca>
Contributor
|
ill re-approve after you fix phpcs! |
zaliqarosli
approved these changes
Dec 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
These changes were made to reflect the #6923 which was issued to the
mainbranchAdditional changes not in #6923:
_dateif it is positioned at the end of the field name. For example if the user names their date fieldmy_date_of_release_date, previously the function would strip the field name tomy; now it would only strip the last_dateto becomemy_date_of_releaseisset($dateformat)since the code is already converting a null $dateformat to an empty string 2 lines above !