Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brainbrowser 2.5.5: More bug fix for HDF5 reader error: Redmine 13333 #3275

Closed

Conversation

MounaSafiHarab
Copy link
Contributor

Sequel to #3068 and #3110,
based off of BrainBrowser latest pull request (technical details/description of the changes in the pull request by @rdvincent): aces/brainbrowser#339
that will be released once this PR is merged: aces/brainbrowser#340

@MounaSafiHarab MounaSafiHarab added Category: Bug PR or issue that aims to report or fix a bug [branch] bugfix labels Nov 13, 2017
@MounaSafiHarab MounaSafiHarab added this to the 18.0.5 milestone Nov 13, 2017
@MounaSafiHarab MounaSafiHarab added the State: Blocked PR or issue awaiting an external event such as the merge or another PR to proceed label Nov 13, 2017
@MounaSafiHarab
Copy link
Contributor Author

MounaSafiHarab commented Nov 13, 2017

Added the label 'Blocked' just to wait until 2.5.5 is officially released on aces/brainbrowser
Tagged as BugFix because currently CCNA has scans on production from one site that can not load and get the HDF5 error.

@MounaSafiHarab
Copy link
Contributor Author

@davidblader
I believe CCNA is the only project experiencing this issue; more specifically with the HMC candidates. Can you test this please? I already did on the HMC as well as all other sites, and all looks fine. We now load everything without any HDF5 error thrown. But you can double check.
Pay attention to both structural modalities and those with time-dimension (resting state for example).

@Jkat @llevitis @sruthymathew123
Can you please check that your existing scans load with this version of brainbrowser? One scan per site/candidate would be ideal.

@ridz1208
Copy link
Collaborator

@MounaSafiHarab is this minor or bugfix ??

@MounaSafiHarab MounaSafiHarab changed the base branch from minor to bugfix November 13, 2017 18:44
@MounaSafiHarab
Copy link
Contributor Author

@MounaSafiHarab is this minor or bugfix ??

bugfix. When I created the branch, I was based off of bugfix. I just forgot to change the default pull request branch from minor. Done now. Thanks!

@MounaSafiHarab
Copy link
Contributor Author

MounaSafiHarab commented Nov 13, 2017

@kongtiaowang

I don't understand why Travis is trying to source a test/RBdata.sql and it can not find it (as if it is still thinking we are on the minor branch although I clearly changed the branch to bugfix). My changes here are clearly unrelated....

@MounaSafiHarab
Copy link
Contributor Author

MounaSafiHarab commented Nov 13, 2017

I will close this and issue a new one (#3278).
Travis does not want to update the branch to bugfix when it is doing its tests; it still uses code from the minor branch. So closing and re-issuing properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Bug PR or issue that aims to report or fix a bug State: Blocked PR or issue awaiting an external event such as the merge or another PR to proceed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants