Skip to content

Fix: More explicit message for duplicate timepoint #10259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
arnav-makkar wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: More explicit message for duplicate timepoint #10259

arnav-makkar wants to merge 1 commit into from
+32 −9

Conversation

@arnav-makkar
Copy link
Contributor

@arnav-makkar arnav-makkar commented Jan 10, 2026

Brief summary of changes

Updated the error message displayed when attempting to create a duplicate timepoint to be more explicit and user-friendly.

Before:

This visit label is not unique.

After:

A timepoint with these conditions (PSCID, Project, Cohort, Visit) already exists.

The new message now includes:

  • Participant PSCID
  • Project name
  • Cohort title
  • Visit label

Changes made:

  • Modified TimePoint::isValidVisitLabel() to construct a detailed error message
  • Updated translation files (.pot, .po) for English, Spanish, French, and Japanese

Link(s) to related issue(s)

@github-actions github-actions bot added Language: PHP PR or issue that update PHP code Module: create_timepoint PR or issue related to create_timepoint module Multilingual Any tasks related to making LORIS multilingual labels Jan 10, 2026
@CamilleBeau CamilleBeau requested a review from racostas January 19, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@racostas racostas Awaiting requested review from racostas

At least 1 approving review is required to merge this pull request.

Assignees

@racostas racostas

Labels

Language: PHP PR or issue that update PHP code Module: create_timepoint PR or issue related to create_timepoint module Multilingual Any tasks related to making LORIS multilingual

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[create_timepoint] more explicit messages

2 participants

@arnav-makkar @racostas