Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common - Unquote math #10795

Merged
merged 2 commits into from
Mar 12, 2025
Merged

Common - Unquote math #10795

merged 2 commits into from
Mar 12, 2025

Conversation

BrettMayson
Copy link
Member

When merged this pull request will:

  • Unquote math that HEMTT can do at compile time

Related discussion, should HEMTT also want numbers in strings to be just numbers? Like w = "1";, should it suggest doing w = 1;?

@@ -27,7 +27,7 @@ class CfgWeapons {
reticleDetailTextures[] = {
// start at > this magnification, reticleTexture, reticleTextureSize, reticleTextureNight (optional)
{0, QPATHTOF(data\ace_spottingscope_reticle_b1_ca.paa), 1, QPATHTOF(data\ace_spottingscope_reticle_b1_ca.paa)},
{9, QPATHTOF(data\ace_spottingscope_reticle_b2_ca.paa), "1/2", QPATHTOF(data\ace_spottingscope_reticle_b2_ca.paa)},
{9, QPATHTOF(data\ace_spottingscope_reticle_b2_ca.paa), 1/2, QPATHTOF(data\ace_spottingscope_reticle_b2_ca.paa)},
{14, QPATHTOF(data\ace_spottingscope_reticle_b3_ca.paa), "1/3", QPATHTOF(data\ace_spottingscope_reticle_b3_ca.paa)},
{19, QPATHTOF(data\ace_spottingscope_reticle_b4_ca.paa), "1/4", QPATHTOF(data\ace_spottingscope_reticle_b4_ca.paa)},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint might only be going 1 level deep on arrays I will take a look

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this was a global find and replace for 1/2 since it was common, HEMTT never flagged the others

@PabstMirror
Copy link
Contributor

BrettMayson/HEMTT#919 causes false error in frag
means this won't build pre-1.14.6
so we just want to wait a bit for that to become fully available

@PabstMirror
Copy link
Contributor

PabstMirror commented Mar 11, 2025

wrapping #define BASE_DRAG (-0.01) makes it backward compatible so this is good to go
tested with hemtt 1.14.2

@PabstMirror PabstMirror added this to the 3.19.1 milestone Mar 11, 2025
@PabstMirror PabstMirror added the kind/optimization Release Notes: **IMPROVED:** label Mar 11, 2025
@PabstMirror PabstMirror merged commit 918dc3b into acemod:master Mar 12, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/optimization Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants