Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disarming - Code cleanup #10791

Merged
merged 3 commits into from
Mar 12, 2025
Merged

Disarming - Code cleanup #10791

merged 3 commits into from
Mar 12, 2025

Conversation

johnb432
Copy link
Contributor

@johnb432 johnb432 commented Mar 9, 2025

When merged this pull request will:

  • Title.
  • Header fixes.
  • Optimisations.
  • Changes:
    • Use lifeState instead of getVariable "ACE_isUnconscious" for unconsciousness.
    • Players can only disarm units that are either in the same vehicle as them or if player and target are both on foot.
      Not too sure about this change, but imo it's weird to be able to disarm a person in a vehicle, when you are not in it.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/optimization Release Notes: **IMPROVED:** label Mar 9, 2025
@PabstMirror
Copy link
Contributor

haven't looked at this module in a long time, I know it's a little rough
all your changes look great, thanks

@PabstMirror PabstMirror added this to the 3.19.1 milestone Mar 11, 2025
@PabstMirror PabstMirror merged commit 391af29 into master Mar 12, 2025
3 checks passed
@PabstMirror PabstMirror deleted the disarm-code-cleanup branch March 12, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/optimization Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants