Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate SESOF MagRepack #51

Merged
merged 39 commits into from
Jun 26, 2024
Merged

Integrate SESOF MagRepack #51

merged 39 commits into from
Jun 26, 2024

Conversation

kveberg
Copy link
Contributor

@kveberg kveberg commented Apr 13, 2024

Adds SESOF MagRepack to ACE Anvil.

  • Please somehow note the contributions of Badger 2-3 to this mod -https://github.com/JBraunsmaJr
  • This mod presently does not work with consoles because it hooks into drag-and-drop they do not have

@Kexanone Kexanone added the kind/feature Release Notes: **ADDED:** label Apr 13, 2024
@Kexanone Kexanone added this to the 1.1.0 milestone Apr 13, 2024
@Kexanone
Copy link
Member

Kexanone commented Apr 14, 2024

I updated the folder structure, code style and added ACE prefixes. Make sure to add all contributors to AUTHORS. Also it would be good to have a short entry in the docs for the mod with a hint that it originally was SESOF MagRepack and that it's not console compatible.

Kexanone and others added 5 commits April 14, 2024 08:17
Added authors of magrepack to list of contributors.
Changed GUID from SESOF MagRepack's to a new one.
Exhausted magazines that are dropped to the ground now hold 0 rounds as they should.
@Kexanone Kexanone mentioned this pull request Apr 16, 2024
@Kexanone Kexanone added the 1.2.0.x Arma Reforger version 1.2.0.x label May 24, 2024
@Kexanone Kexanone changed the base branch from master to experimental May 26, 2024 13:52
@Kexanone Kexanone mentioned this pull request May 27, 2024
kveberg and others added 9 commits May 30, 2024 22:56
…nventoryMenuUI.c

Co-authored-by: Kex <kexanone@gmail.com>
…nventoryMenuUI.c

Co-authored-by: Kex <kexanone@gmail.com>
…ontroller.c

Co-authored-by: Kex <kexanone@gmail.com>
…ontroller.c

Co-authored-by: Kex <kexanone@gmail.com>
Changed Print()-statements to LogLevel.DEBUG
Added parent class to initial modded statement
Added parent class to initial modded statement
Set Print()-statements to LogLevel.DEBUG
Added two missing return statements, 124 and 130
…ontroller.c

Co-authored-by: Kex <kexanone@gmail.com>
@kveberg
Copy link
Contributor Author

kveberg commented Jun 12, 2024

I thought I had fixed all these, but apparently had not. Should be good now.

kveberg and others added 3 commits June 13, 2024 21:00
…ontroller.c

Co-authored-by: Kex <kexanone@gmail.com>
…nventoryMenuUI.c

Co-authored-by: Kex <kexanone@gmail.com>
…nventoryMenuUI.c

Co-authored-by: Kex <kexanone@gmail.com>
@Kexanone Kexanone merged commit 8891983 into acemod:experimental Jun 26, 2024
Kexanone added a commit that referenced this pull request Jun 26, 2024
* Create readme.md

* Add files via upload

* Update thumbnail

* Remove extra files

* Rename addon

* Update folder structure and file names

* Update code style

* Add ACE prefix to methods

* Add space after if

* Update AUTHORS

Added authors of magrepack to list of contributors.

* Create magrepack.mdx

* Update addon.gproj

Changed GUID from SESOF MagRepack's to a new one.

* Update SCR_PlayerController.c

Exhausted magazines that are dropped to the ground now hold 0 rounds as they should.

* Update AUTHORS

Authors now sort alphabetically

* Update docs/src/content/docs/components/magrepack.mdx

Co-authored-by: Kex <kexanone@gmail.com>

* Update docs/src/content/docs/components/magrepack.mdx

Co-authored-by: Kex <kexanone@gmail.com>

* Update magrepack.mdx

* Update SCR_PlayerController.c

* Update SCR_InventoryMenuUI.c

* Update magrepack.mdx

Added description of how the mod works with gamepads

* Update docs/src/content/docs/components/magrepack.mdx

Co-authored-by: jonpas <jonpas33@gmail.com>

* Update addons/magrepack/scripts/Game/ACE_MagRepack/UI/Inventory/SCR_InventoryMenuUI.c

Co-authored-by: Kex <kexanone@gmail.com>

* Update addons/magrepack/scripts/Game/ACE_MagRepack/UI/Inventory/SCR_InventoryMenuUI.c

Co-authored-by: Kex <kexanone@gmail.com>

* Update addons/magrepack/scripts/Game/ACE_MagRepack/Player/SCR_PlayerController.c

Co-authored-by: Kex <kexanone@gmail.com>

* Update addons/magrepack/scripts/Game/ACE_MagRepack/Player/SCR_PlayerController.c

Co-authored-by: Kex <kexanone@gmail.com>

* Update SCR_PlayerController.c

Changed Print()-statements to LogLevel.DEBUG
Added parent class to initial modded statement

* Update SCR_InventoryMenuUI.c

Added parent class to initial modded statement
Set Print()-statements to LogLevel.DEBUG

* Update SCR_PlayerController.c

Added two missing return statements, 124 and 130

* Update SCR_InventoryMenuUI.c

* Update addons/magrepack/scripts/Game/ACE_MagRepack/Player/SCR_PlayerController.c

Co-authored-by: Kex <kexanone@gmail.com>

* Update addons/magrepack/scripts/Game/ACE_MagRepack/Player/SCR_PlayerController.c

Co-authored-by: Kex <kexanone@gmail.com>

* Update addons/magrepack/scripts/Game/ACE_MagRepack/UI/Inventory/SCR_InventoryMenuUI.c

Co-authored-by: Kex <kexanone@gmail.com>

* Update addons/magrepack/scripts/Game/ACE_MagRepack/UI/Inventory/SCR_InventoryMenuUI.c

Co-authored-by: Kex <kexanone@gmail.com>

---------

Co-authored-by: Kex <kexanone@gmail.com>
Co-authored-by: jonpas <jonpas33@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.2.0.x Arma Reforger version 1.2.0.x kind/feature Release Notes: **ADDED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants