Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chopping - Replace ActionsManagerComponent on plant with helper #48

Merged
merged 4 commits into from
Apr 17, 2024

Conversation

Kexanone
Copy link
Member

@Kexanone Kexanone commented Apr 13, 2024

When merged this pull request will:

  • Reduce memory requirement by using a dynamic spawned helper entity for providing the chopping action instead of an actions manager on all plants.
  • Resolves Chopping - Memory related crashes #50

Notes on the implementation:

  • The E-tool already has a dynamic handler for spawning/despawning building previews, hence we just use those methods for our helper system.

@Kexanone Kexanone added the kind/enhancement Release Notes: **IMPROVED:** label Apr 13, 2024
@Kexanone Kexanone added this to the 1.0.2 milestone Apr 13, 2024
Copy link
Member

@veteran29 veteran29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great solution!

@Kexanone Kexanone merged commit 40e6bd2 into master Apr 17, 2024
@Kexanone Kexanone deleted the chopping-helper-entity branch April 17, 2024 10:28
@Kexanone Kexanone restored the chopping-helper-entity branch February 20, 2025 21:52
@Kexanone Kexanone deleted the chopping-helper-entity branch February 20, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chopping - Memory related crashes
2 participants