Skip to content

Commit

Permalink
MIPS: signal: Return immediately if call fails
Browse files Browse the repository at this point in the history
When debug sigaltstack(), copy_siginfo_to_user() fails first in
setup_rt_frame() if the alternate signal stack is too small, so
it should return immediately if call fails, no need to call the
following functions.

Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
  • Loading branch information
seehearfeel authored and tsbogend committed Jan 2, 2022
1 parent 0ebd37a commit 408bd9d
Showing 1 changed file with 11 additions and 9 deletions.
20 changes: 11 additions & 9 deletions arch/mips/kernel/signal.c
Original file line number Diff line number Diff line change
Expand Up @@ -754,23 +754,25 @@ static int setup_rt_frame(void *sig_return, struct ksignal *ksig,
struct pt_regs *regs, sigset_t *set)
{
struct rt_sigframe __user *frame;
int err = 0;

frame = get_sigframe(ksig, regs, sizeof(*frame));
if (!access_ok(frame, sizeof (*frame)))
return -EFAULT;

/* Create siginfo. */
err |= copy_siginfo_to_user(&frame->rs_info, &ksig->info);
if (copy_siginfo_to_user(&frame->rs_info, &ksig->info))
return -EFAULT;

/* Create the ucontext. */
err |= __put_user(0, &frame->rs_uc.uc_flags);
err |= __put_user(NULL, &frame->rs_uc.uc_link);
err |= __save_altstack(&frame->rs_uc.uc_stack, regs->regs[29]);
err |= setup_sigcontext(regs, &frame->rs_uc.uc_mcontext);
err |= __copy_to_user(&frame->rs_uc.uc_sigmask, set, sizeof(*set));

if (err)
if (__put_user(0, &frame->rs_uc.uc_flags))
return -EFAULT;
if (__put_user(NULL, &frame->rs_uc.uc_link))
return -EFAULT;
if (__save_altstack(&frame->rs_uc.uc_stack, regs->regs[29]))
return -EFAULT;
if (setup_sigcontext(regs, &frame->rs_uc.uc_mcontext))
return -EFAULT;
if (__copy_to_user(&frame->rs_uc.uc_sigmask, set, sizeof(*set)))
return -EFAULT;

/*
Expand Down

0 comments on commit 408bd9d

Please sign in to comment.