Skip to content

Commit

Permalink
mtip32xx: Use plain spinlock for 'cmd_issue_lock'
Browse files Browse the repository at this point in the history
'cmd_issue_lock' is for only acquiring a free slot, and it is not used
in interrupt context. So replaced irq version with non-irq version of spinlock.

Signed-off-by: Asai Thambi S P <asamymuthupa@micron.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
  • Loading branch information
asaithambi authored and axboe committed May 31, 2012
1 parent 6c8ab69 commit 0a07ab2
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions drivers/block/mtip32xx/mtip32xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -294,18 +294,16 @@ static int hba_reset_nosleep(struct driver_data *dd)
*/
static inline void mtip_issue_ncq_command(struct mtip_port *port, int tag)
{
unsigned long flags = 0;

atomic_set(&port->commands[tag].active, 1);

spin_lock_irqsave(&port->cmd_issue_lock, flags);
spin_lock(&port->cmd_issue_lock);

writel((1 << MTIP_TAG_BIT(tag)),
port->s_active[MTIP_TAG_INDEX(tag)]);
writel((1 << MTIP_TAG_BIT(tag)),
port->cmd_issue[MTIP_TAG_INDEX(tag)]);

spin_unlock_irqrestore(&port->cmd_issue_lock, flags);
spin_unlock(&port->cmd_issue_lock);

/* Set the command's timeout value.*/
port->commands[tag].comp_time = jiffies + msecs_to_jiffies(
Expand Down

0 comments on commit 0a07ab2

Please sign in to comment.