Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding ci workflow for ginkgo tests #650

Merged
merged 2 commits into from
Jan 12, 2023
Merged

adding ci workflow for ginkgo tests #650

merged 2 commits into from
Jan 12, 2023

Conversation

Prateeknandle
Copy link
Contributor

Signed-off-by: Prateeknandle prateeknandle@gmail.com

Ankurk99
Ankurk99 suggested changes Jan 11, 2023
View reviewed changes
.github/workflows/ci-go.yml Show resolved Hide resolved
.github/workflows/ci-go.yml Outdated Show resolved Hide resolved
@Ankurk99
Copy link
Contributor

Can you please look into the ci-go failure?

@Prateeknandle
Copy link
Contributor Author

Can you please look into the ci-go failure?

right now it will fail because there is no test case present in tests folder

@Prateeknandle
Copy link
Contributor Author

@rksharma95 does this satisfies our requirements ?

@rksharma95
Copy link
Contributor

@Prateeknandle i think we'll require KubeArmor up and running too for these e2e tests.

@Prateeknandle
Copy link
Contributor Author

@Prateeknandle i think we'll require KubeArmor up and running too for these e2e tests.

sorry i thought it was implemented in ginkgo tests

@Prateeknandle
adding ci workflow for ginkgo tests
ecf328e 
Signed-off-by: Prateeknandle <prateeknandle@gmail.com>
@nyrahul
Copy link
Contributor

nyrahul commented Jan 12, 2023

Hey @Prateeknandle, why is the ginkgo-test failing in this PR?

@Prateeknandle
Copy link
Contributor Author

Hey @Prateeknandle, why is the ginkgo-test failing in this PR?

because right now there are no test present in the current working directory. It is meant to be fail.

@Prateeknandle
Copy link
Contributor Author

@rksharma95 please review the pr

@rksharma95
Copy link
Contributor

@Prateeknandle can you please add a sample test so we can have a green pipeline. thanks

@Prateeknandle
sample test
ecc1686 
Signed-off-by: Prateeknandle <prateeknandle@gmail.com>
@Prateeknandle
Copy link
Contributor Author

@rksharma95 does this test works?

rksharma95
rksharma95 approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@rksharma95 rksharma95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Prateeknandle
Copy link
Contributor Author

@Ankurk99 can u please review the pr

@Prateeknandle Prateeknandle merged commit 12a2395 into accuknox:dev Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rksharma95 rksharma95 rksharma95 approved these changes

@Ankurk99 Ankurk99 Ankurk99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Prateeknandle @Ankurk99 @rksharma95 @nyrahul