Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bind port connection details (SYS_BIND) #624

Merged
merged 1 commit into from
Dec 6, 2022
Merged

bind port connection details (SYS_BIND) #624

merged 1 commit into from
Dec 6, 2022

Conversation

yasin-cs-ko-ak
Copy link
Contributor

This PR Contains bind port connection for summarised data

  • Using SYS_BIND to get bind port
  • sin_port and sin_addr used for bind port and bind address respectively.

seswarrajan
seswarrajan approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@seswarrajan seswarrajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Have you tested the same with karmor CLI ?
There are changes required in karmor CLI as well.

@yasin-cs-ko-ak
Copy link
Contributor Author

LGTM Have you tested the same with karmor CLI ? There are changes required in karmor CLI as well.

@seswarrajan I manually printed the results and tested. Since it requires proto updation. After this PR gets merged. I'll raise pr in kubearmor-client.

@nyrahul nyrahul merged commit 45c77dd into accuknox:dev Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seswarrajan seswarrajan seswarrajan approved these changes

@vishnusomank vishnusomank vishnusomank approved these changes

@nyrahul nyrahul nyrahul approved these changes

@achrefbensaad achrefbensaad Awaiting requested review from achrefbensaad

@Ankurk99 Ankurk99 Awaiting requested review from Ankurk99

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yasin-cs-ko-ak @nyrahul @vishnusomank @seswarrajan