Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Workspace Id to publisher proto #590

Merged
merged 2 commits into from
Nov 14, 2022
Merged

Add Workspace Id to publisher proto #590

merged 2 commits into from
Nov 14, 2022

Conversation

seswarrajan
Copy link
Contributor

Signed-off-by: Eswar Rajan Subramanian eswar@accuknox.com

Signed-off-by: Eswar Rajan Subramanian <eswar@accuknox.com>
Signed-off-by: Eswar Rajan Subramanian <eswar@accuknox.com>
@Ankurk99
Copy link
Contributor

What is this workspace_id and how will it be useful for us?

@seswarrajan
Copy link
Contributor Author

What is this workspace_id and how will it be useful for us?

While onboarding a worker cluster, each worker cluster is given an unique workspace ID. This workspace Id will help in identifying that worker cluster. This will be more helpful in SaaS .

Copy link
Contributor

@rajaSahil rajaSahil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wazir-ahmed
Copy link
Contributor

wazir-ahmed commented Nov 14, 2022

@seswarrajan How DE knows the workspace_id for the cluster in which it is running? Are we using config params or env vars?

@seswarrajan
Copy link
Contributor Author

We set it as env variable while onboarding the cluster.

image

@wazir-ahmed
Copy link
Contributor

We set it as env variable while onboarding the cluster.

Okay, we already added the support for it, 🚀

@seswarrajan
Copy link
Contributor Author

We set it as env variable while onboarding the cluster.

Okay, we already added the support for it, rocket

From feeder-service ?

@wazir-ahmed
Copy link
Contributor

From feeder-service ?

My question is, if I add the workspace, cluster_name env to DE today, will it work?

@seswarrajan
Copy link
Contributor Author

From feeder-service ?

My question is, if I add the workspace, cluster_name env to DE today, will it work?

With this PR, if we add workpsaceId and cluster_name to the env, it will work.

@seswarrajan seswarrajan merged commit 760d5c9 into accuknox:dev Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants