-
Notifications
You must be signed in to change notification settings - Fork 46
(chore) update to use markdown-transform #96
Conversation
Signed-off-by: Dan Selman <danscode@selman.org>
Signed-off-by: Dan Selman <danscode@selman.org>
Signed-off-by: Dan Selman <danscode@selman.org>
| }, | ||
| "scripts": { | ||
| "test": "jest", | ||
| "test": "jest --passWithNoTests", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this temporary until new tests are created?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes -- and it only seems to be needed for the Travis build. Not sure why.
Signed-off-by: Dan Selman <danscode@selman.org>
| newSchema.document.nodes[0].match.push({ type: 'ul_list' }); | ||
| return newSchema; | ||
| }); | ||
| const name = 'list'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still used? Not seeing it in this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's used by the PluginManager to deterministically sort the plugins so they get applied in the same order.
|
Curious why we remove the video plugin? |
|
I think moving the |
Because the |
jolanglinais
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks great to me.
Signed-off-by: Dan Selman <danscode@selman.org>
Signed-off-by: Dan Selman danscode@selman.org
Changes
markdown-transformfor Slate <> Markdown conversionFlags
Listplugin altogether and just bake that into theSlateAsInputEditor?