Skip to content
This repository was archived by the owner on May 19, 2020. It is now read-only.

Conversation

@dselman
Copy link
Contributor

@dselman dselman commented Oct 3, 2019

Signed-off-by: Dan Selman danscode@selman.org

Changes

  • Update to use markdown-transform for Slate <> Markdown conversion
  • Removed markdown <> HTML conversion from plugins

Flags

  • Plugins are now purely for controlling Slate editor behaviour, they cannot extend markdown serialisation as that is handled by markdown-transform
  • Do we want to remove the List plugin altogether and just bake that into the SlateAsInputEditor?

Signed-off-by: Dan Selman <danscode@selman.org>
@dselman dselman requested a review from jolanglinais October 3, 2019 15:42
Signed-off-by: Dan Selman <danscode@selman.org>
Signed-off-by: Dan Selman <danscode@selman.org>
},
"scripts": {
"test": "jest",
"test": "jest --passWithNoTests",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this temporary until new tests are created?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes -- and it only seems to be needed for the Travis build. Not sure why.

Signed-off-by: Dan Selman <danscode@selman.org>
newSchema.document.nodes[0].match.push({ type: 'ul_list' });
return newSchema;
});
const name = 'list';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still used? Not seeing it in this file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's used by the PluginManager to deterministically sort the plugins so they get applied in the same order.

@jolanglinais
Copy link
Member

Curious why we remove the video plugin?

@jolanglinais
Copy link
Member

I think moving the List plugin altogether and just baking that into the SlateAsInputEditor makes sense, it feels like it's an integral attribute that doesn't need to be abstracted into a plugin.

@dselman
Copy link
Contributor Author

dselman commented Oct 3, 2019

Curious why we remove the video plugin?

Because the markdown-transform would need to be extended to handle the conversion from/to Slate.

Copy link
Member

@jolanglinais jolanglinais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great to me.

Signed-off-by: Dan Selman <danscode@selman.org>
@dselman dselman merged commit 4b407f1 into master Oct 3, 2019
@dselman dselman deleted the ds-use-markdown-transform branch October 3, 2019 18:37
@jolanglinais jolanglinais added Type: Enhancement ✨ Improvement to process or efficiency Type: Release 📅 Major or minor release labels Oct 3, 2019
@jolanglinais jolanglinais added this to the 0.6.0 milestone Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Type: Enhancement ✨ Improvement to process or efficiency Type: Release 📅 Major or minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants