[WIP][PAC] Emit IR debug info metadata nodes for implicitly signed pointers #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kovdan01
force-pushed
the
dkovalev/pauth-dwarf
branch
from
366b203 to
c9c3472
Compare
…inters Emit debug metadata nodes with `DW_TAG_LLVM_ptrauth_type` tag containing signing scheme info for the following types of implicitly (without `__ptrauth` specifier) signed pointers: - virtual table pointers; - free function pointers; - member function pointers.
kovdan01
force-pushed
the
dkovalev/pauth-dwarf
branch
from
c9c3472 to
0e3c7fa
Compare
|
Tagging @ahmedbougacha |
|
In any case, we need to get info about ABI signing schema used by debuggee in order to pass desired flags to compiler in context of user expression evaluation. Given that, if we know the ABI, there is no reason in emitting ptrauth dwarf data for implicitly signed pointers - the compiler will sign them properly when we pass signing flags used by ABI to the compiler. So, in Dwarf we only need to have info about explicitly signed pointers. Closing this as not needed anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emit debug metadata nodes with
DW_TAG_LLVM_ptrauth_typetag containing signing scheme info for the following types of implicitly (without__ptrauthspecifier) signed pointers: