Undefine ERROR on Windows platform #29
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromehaxhiaj-qti
changed the title
jeromehaxhiaj-qti
force-pushed
the
undefine_error_win32
branch
from
1a562b2 to
6e4f0a4
Compare
Due to ERROR being a macro defined on Windows platforms, we need to #undef it to avoid a collision with log:ERROR.
jeromehaxhiaj-qti
force-pushed
the
undefine_error_win32
branch
from
6e4f0a4 to
e2b921d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to ERROR being a macro defined on Windows platforms,
we need to #undef it to avoid a collision with log:ERROR.