Fix site URL in links when running locally with docker compose or DevContainer

[nathanpainchaud]

Fixes #3028.

[rjzupkoii]

Thanks for this change!

[msk-nightly]

For some reason, this change doesn't allow me to load the site properly from localhost:4000 but, rather, I specifically have to go to 0.0.0.0:4000. Also, when I checked separately, this results in the static files generated in the _site directory to all have 0.0.0.0 in the links.

[nathanpainchaud]

when I checked separately, this results in the static files generated in the _site directory to all have 0.0.0.0 in the links.

The 0.0.0.0 URL in the links (instead of localhost) is expected, because that's the URL that is configured in the docker commands, i.e. jekyll serve -H 0.0.0.0 -w.

For some reason, this change doesn't allow me to load the site properly from localhost:4000 but, rather, I specifically have to go to 0.0.0.0:4000.

When I manually switch 0.0.0.0 for localhost I am still able to load the expected page. So localhost should still work, it's just not the default URL.

For context, when testing this PR, I tried removing the -H 0.0.0.0 to fallback the default localhost, but in that case I was not able to load the site anymore. I've seen 0.0.0.0 used in many tutorials for setting up Jekyll websites within docker, so I assumed it was common practice to work well with docker. But I didn't have the knowledge/time to understand why the default localhost is not working with docker.

When you say

this change doesn't allow me to load the site properly from localhost:4000

do you mean that you were able to previously? Because in my experience the previous configuration was also serving to 0.0.0.0 (and not localhost), and the links pointed to deployment URL, not any local server.

[msk-nightly]

Thank you for the prompt response. Yes, I do understand but before the jekyll serve command was added to the docker compose file, I was able to load the site properly (entire UI) from localhost:4000 and 0.0.0.0:4000. Now, it loads properly from 0.0.0.0:4000 only and loads without the proper styling and UI from localhost:4000 (weirdly enough). Could be some other issue. Thank you again for taking the time to check and reply thoroughly.

[nathanpainchaud]

Yes, I do understand but before the jekyll serve command was added to the docker compose file [...]

@msk-nightly I think it would help if you could point to a specific commit that worked like you expected. Because this PR did not introduce the jekyll serve command to the docker compose file. jekyll serve was already there, and I've just modified the arguments.

I didn't test the docker integration prior to ef8e08b (the version that I modified), so I can't comment on whether or not serving at localhost worked better before that.

[msk-nightly]

Thank you for your prompt response. I understand. You are correct in mentioning that this PR did not introduce the jekyll serve command to the docker compose file but you introduced it in a previous PR corresponding to the commit 6f5947f. I just mentioned it here because it's the latest one in that series. Also, while I'm not sure what the effect of these two commits is due to my own lack of knowledge regarding Dockerfiles, it worked just fine before - which I know since I've been keeping my repo synced. Thanks again.

[nathanpainchaud]

You are correct in mentioning that this PR did not introduce the jekyll serve command to the docker compose file but you introduced it in a previous PR corresponding to the commit 6f5947f.

@msk-nightly The commit you point to IS the commit introduced by the PR... The PR added two commits, 6f5947f with the changes, and d4e74ea which is just a merge commit.
Your way of phrasing things confused me. The changes did not introduce the jekyll serve command, they simply changed the options. But I assume now that's what you mean by "introduce"?

Also, while I'm not sure what the effect of these two commits is due to my own lack of knowledge regarding Dockerfiles, it worked just fine before - which I know since I've been keeping my repo synced.

Tthe PR fixed an issue that WAS there before (detailed in #3028), so things were apparently not working fine for all configurations...

If you want to investigate this further, I'd suggest you open a new issue describing more clearly the issue you're experiencing (what styling is not loading?) and provide details about your setup (e.g. docker, jekyll & ruby versions). Maybe then other people will be able to help. As things stand, I can't replicate your issues with up-to-date docker and jekyll...

[msk-nightly]

My apologies. It seems you're right. The command was introduced to the docker-compose.yaml file by one Adrian Auer in commit 37a2589 and not you. I mixed things up in checking the commit history. So, things were working fine before that with up-to-date docker and jekyll. I now stand corrected. Thank you for your time and patience in this thread. I'll move this elsewhere, God willing.