Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Scroll Functionality to Sidebar #2025

Merged
merged 4 commits into from
Apr 4, 2024

Conversation

MaxGalindo150
Copy link
Contributor

This pull request adds scroll functionality to the sidebar. This is achieved by setting the height of the sidebar to 100vh and enabling overflow-y to auto. This ensures that the sidebar is always the full height of the viewport, and if the content exceeds this height, the user can scroll down to see the rest of the content. This improves the user experience by making navigation easier and more intuitive.

@rjzupkoii
Copy link
Collaborator

Thanks for the pull request, have you tested the change in mobile views yet?

@rjzupkoii rjzupkoii self-assigned this Mar 31, 2024
@rjzupkoii rjzupkoii added the enhancement An enhancement. label Mar 31, 2024
@MaxGalindo150
Copy link
Contributor Author

Yes, the changes have been tested on mobile views. The media query ensures that the scrolling functionality and fixed position of the sidebar are applied only when the screen width is 925px or wider. For screens narrower than 925px, the sidebar behaves as it did before, ensuring that the mobile view remains unaffected.

@rjzupkoii rjzupkoii merged commit fb28163 into academicpages:master Apr 4, 2024
0vlax0 added a commit to 0vlax0/io that referenced this pull request Apr 5, 2024
0vlax0 added a commit to 0vlax0/io that referenced this pull request Apr 5, 2024
pendiente: revisar error con commit 
 Added Scroll Functionality to Sidebar academicpages#2025 
academicpages#2025
Guancheng1 pushed a commit to Guancheng1/Guancheng1.github.io that referenced this pull request Nov 8, 2024
schanghydro pushed a commit to schanghydro/schanghydro.github.io that referenced this pull request Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants