Skip to content

Release 6.1.1 (Bugfix) #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 2, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
# next release

# 6.1.1

Fixes:
- Problems with `--axios` option
- ignoring `path`, `format`, `type` payload properties in `request()` method of `HttpClient`
- Missing `format` property for requests in `--modular` option

# 6.1.0

Features:
- `--silent` option. Output only errors to console (default: false)

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

Generate api via swagger scheme.
Supports OA 3.0, 2.0, JSON, yaml
Generated api module use [**Fetch Api**](https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API) to make requests.
Generated api module use [**Fetch Api**](https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API) or [**Axios**](https://github.com/axios/axios) to make requests.

<br>
<br>
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "swagger-typescript-api",
"version": "6.1.0",
"version": "6.1.1",
"description": "Create typescript api module from swagger schema",
"scripts": {
"cli:json": "node index.js -r -d -p ./swagger-test-cli.json -n swagger-test-cli.ts --extract-request-params --enum-names-as-values",
Expand Down Expand Up @@ -32,6 +32,7 @@
"test:--js": "node tests/spec/js/test.js",
"test:--js--axios": "node tests/spec/jsAxios/test.js",
"test:--axios": "node tests/spec/axios/test.js",
"test:--axios--single-http-client": "node tests/spec/axiosSingleHttpClient/test.js",
"test:partialBaseTemplate": "node tests/spec/partialBaseTemplate/test.js",
"test:partialDefaultTemplate": "node tests/spec/partialDefaultTemplate/test.js"
},
Expand Down
9 changes: 5 additions & 4 deletions templates/base/http-clients/axios-http-client.eta
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
<%
const { apiConfig, generateResponses } = it;
%>
import axios, { AxiosInstance, AxiosRequestConfig, AxiosResponse } from "axios";
import axios, { AxiosInstance, AxiosRequestConfig, AxiosResponse, ResponseType } from "axios";

export type QueryParamsType = Record<string | number, any>;
export type ResponseFormat = keyof Omit<Body, "body" | "bodyUsed">;

export interface FullRequestParams extends Omit<AxiosRequestConfig, "data" | "params"> {
export interface FullRequestParams extends Omit<AxiosRequestConfig, "data" | "params" | "url" | "responseType"> {
/** set parameter to `true` for call `securityWorker` for this request */
secure?: boolean;
/** request path */
Expand All @@ -16,7 +15,7 @@ export interface FullRequestParams extends Omit<AxiosRequestConfig, "data" | "pa
/** query params */
query?: QueryParamsType;
/** format of response (i.e. response.json() -> format: "json") */
format?: keyof Omit<Body, "body" | "bodyUsed">;
format?: ResponseType;
/** request body */
body?: unknown;
}
Expand Down Expand Up @@ -77,7 +76,9 @@ export class HttpClient<SecurityDataType = unknown> {
...(requestParams.headers || {}),
},
params: query,
responseType: format,
data: body,
url: path,
});
};
}
2 changes: 1 addition & 1 deletion templates/base/http-clients/fetch-http-client.eta
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export interface FullRequestParams extends Omit<RequestInit, "body"> {
/** query params */
query?: QueryParamsType;
/** format of response (i.e. response.json() -> format: "json") */
format?: keyof Omit<Body, "body" | "bodyUsed">;
format?: ResponseFormat;
/** request body */
body?: unknown;
/** base url */
Expand Down
3 changes: 2 additions & 1 deletion templates/default/procedure-call.eta
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ const { type, errorType, contentTypes } = route.response;
const routeDocs = includeFile("@base/route-docs", { config, route, utils });
const queryName = (query && query.name) || "query";
const pathParams = _.values(parameters);
const isFetchTemplate = config.httpClientType === config.constants.HTTP_CLIENT.FETCH;

const requestConfigParam = {
name: pathParams.some((pathArg) => pathArg.name === "params") ? "requestParams" : "params",
Expand Down Expand Up @@ -51,7 +52,7 @@ const requestContentKind = {
const responseContentKind = {
"JSON": '"json"',
"IMAGE": '"blob"',
"FORM_DATA": '"formData"'
"FORM_DATA": isFetchTemplate ? '"formData"' : '"document"'
}

const bodyTmpl = _.get(payload, "name") || null;
Expand Down
4 changes: 3 additions & 1 deletion templates/modular/procedure-call.eta
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ const { type, errorType, contentTypes } = route.response;
const routeDocs = includeFile("@base/route-docs", { config, route, utils });
const queryName = (query && query.name) || "query";
const pathParams = _.values(parameters);
const isFetchTemplate = config.httpClientType === config.constants.HTTP_CLIENT.FETCH;

const requestConfigParam = {
name: pathParams.some((pathArg) => pathArg.name === "params") ? "requestParams" : "params",
Expand Down Expand Up @@ -51,7 +52,7 @@ const requestContentKind = {
const responseContentKind = {
"JSON": '"json"',
"IMAGE": '"blob"',
"FORM_DATA": '"formData"'
"FORM_DATA": isFetchTemplate ? '"formData"' : '"document"'
}

const bodyTmpl = _.get(payload, "name") || null;
Expand Down Expand Up @@ -90,5 +91,6 @@ const describeReturnType = () => {
<%~ bodyTmpl ? `body: ${bodyTmpl},` : '' %>
<%~ securityTmpl ? `secure: ${securityTmpl},` : '' %>
<%~ bodyContentKindTmpl ? `type: ${bodyContentKindTmpl},` : '' %>
<%~ responseFormatTmpl ? `format: ${responseFormatTmpl},` : '' %>
...<%~ _.get(requestConfigParam, "name") %>,
})
2 changes: 1 addition & 1 deletion tests/generated/v2.0/adafruit.ts
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ export interface FullRequestParams extends Omit<RequestInit, "body"> {
/** query params */
query?: QueryParamsType;
/** format of response (i.e. response.json() -> format: "json") */
format?: keyof Omit<Body, "body" | "bodyUsed">;
format?: ResponseFormat;
/** request body */
body?: unknown;
/** base url */
Expand Down
2 changes: 1 addition & 1 deletion tests/generated/v2.0/another-example.ts
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ export interface FullRequestParams extends Omit<RequestInit, "body"> {
/** query params */
query?: QueryParamsType;
/** format of response (i.e. response.json() -> format: "json") */
format?: keyof Omit<Body, "body" | "bodyUsed">;
format?: ResponseFormat;
/** request body */
body?: unknown;
/** base url */
Expand Down
2 changes: 1 addition & 1 deletion tests/generated/v2.0/another-schema.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export interface FullRequestParams extends Omit<RequestInit, "body"> {
/** query params */
query?: QueryParamsType;
/** format of response (i.e. response.json() -> format: "json") */
format?: keyof Omit<Body, "body" | "bodyUsed">;
format?: ResponseFormat;
/** request body */
body?: unknown;
/** base url */
Expand Down
2 changes: 1 addition & 1 deletion tests/generated/v2.0/api-with-examples.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export interface FullRequestParams extends Omit<RequestInit, "body"> {
/** query params */
query?: QueryParamsType;
/** format of response (i.e. response.json() -> format: "json") */
format?: keyof Omit<Body, "body" | "bodyUsed">;
format?: ResponseFormat;
/** request body */
body?: unknown;
/** base url */
Expand Down
2 changes: 1 addition & 1 deletion tests/generated/v2.0/authentiq.ts
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ export interface FullRequestParams extends Omit<RequestInit, "body"> {
/** query params */
query?: QueryParamsType;
/** format of response (i.e. response.json() -> format: "json") */
format?: keyof Omit<Body, "body" | "bodyUsed">;
format?: ResponseFormat;
/** request body */
body?: unknown;
/** base url */
Expand Down
2 changes: 1 addition & 1 deletion tests/generated/v2.0/example1.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export interface FullRequestParams extends Omit<RequestInit, "body"> {
/** query params */
query?: QueryParamsType;
/** format of response (i.e. response.json() -> format: "json") */
format?: keyof Omit<Body, "body" | "bodyUsed">;
format?: ResponseFormat;
/** request body */
body?: unknown;
/** base url */
Expand Down
2 changes: 1 addition & 1 deletion tests/generated/v2.0/file-formdata-example.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export interface FullRequestParams extends Omit<RequestInit, "body"> {
/** query params */
query?: QueryParamsType;
/** format of response (i.e. response.json() -> format: "json") */
format?: keyof Omit<Body, "body" | "bodyUsed">;
format?: ResponseFormat;
/** request body */
body?: unknown;
/** base url */
Expand Down
2 changes: 1 addition & 1 deletion tests/generated/v2.0/furkot-example.ts
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export interface FullRequestParams extends Omit<RequestInit, "body"> {
/** query params */
query?: QueryParamsType;
/** format of response (i.e. response.json() -> format: "json") */
format?: keyof Omit<Body, "body" | "bodyUsed">;
format?: ResponseFormat;
/** request body */
body?: unknown;
/** base url */
Expand Down
2 changes: 1 addition & 1 deletion tests/generated/v2.0/giphy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ export interface FullRequestParams extends Omit<RequestInit, "body"> {
/** query params */
query?: QueryParamsType;
/** format of response (i.e. response.json() -> format: "json") */
format?: keyof Omit<Body, "body" | "bodyUsed">;
format?: ResponseFormat;
/** request body */
body?: unknown;
/** base url */
Expand Down
2 changes: 1 addition & 1 deletion tests/generated/v2.0/github-swagger.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1447,7 +1447,7 @@ export interface FullRequestParams extends Omit<RequestInit, "body"> {
/** query params */
query?: QueryParamsType;
/** format of response (i.e. response.json() -> format: "json") */
format?: keyof Omit<Body, "body" | "bodyUsed">;
format?: ResponseFormat;
/** request body */
body?: unknown;
/** base url */
Expand Down
2 changes: 1 addition & 1 deletion tests/generated/v2.0/path-args.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export interface FullRequestParams extends Omit<RequestInit, "body"> {
/** query params */
query?: QueryParamsType;
/** format of response (i.e. response.json() -> format: "json") */
format?: keyof Omit<Body, "body" | "bodyUsed">;
format?: ResponseFormat;
/** request body */
body?: unknown;
/** base url */
Expand Down
2 changes: 1 addition & 1 deletion tests/generated/v2.0/petstore-expanded.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export interface FullRequestParams extends Omit<RequestInit, "body"> {
/** query params */
query?: QueryParamsType;
/** format of response (i.e. response.json() -> format: "json") */
format?: keyof Omit<Body, "body" | "bodyUsed">;
format?: ResponseFormat;
/** request body */
body?: unknown;
/** base url */
Expand Down
2 changes: 1 addition & 1 deletion tests/generated/v2.0/petstore-minimal.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export interface FullRequestParams extends Omit<RequestInit, "body"> {
/** query params */
query?: QueryParamsType;
/** format of response (i.e. response.json() -> format: "json") */
format?: keyof Omit<Body, "body" | "bodyUsed">;
format?: ResponseFormat;
/** request body */
body?: unknown;
/** base url */
Expand Down
2 changes: 1 addition & 1 deletion tests/generated/v2.0/petstore-simple.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export interface FullRequestParams extends Omit<RequestInit, "body"> {
/** query params */
query?: QueryParamsType;
/** format of response (i.e. response.json() -> format: "json") */
format?: keyof Omit<Body, "body" | "bodyUsed">;
format?: ResponseFormat;
/** request body */
body?: unknown;
/** base url */
Expand Down
2 changes: 1 addition & 1 deletion tests/generated/v2.0/petstore-swagger-io.ts
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ export interface FullRequestParams extends Omit<RequestInit, "body"> {
/** query params */
query?: QueryParamsType;
/** format of response (i.e. response.json() -> format: "json") */
format?: keyof Omit<Body, "body" | "bodyUsed">;
format?: ResponseFormat;
/** request body */
body?: unknown;
/** base url */
Expand Down
2 changes: 1 addition & 1 deletion tests/generated/v2.0/petstore-with-external-docs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export interface FullRequestParams extends Omit<RequestInit, "body"> {
/** query params */
query?: QueryParamsType;
/** format of response (i.e. response.json() -> format: "json") */
format?: keyof Omit<Body, "body" | "bodyUsed">;
format?: ResponseFormat;
/** request body */
body?: unknown;
/** base url */
Expand Down
2 changes: 1 addition & 1 deletion tests/generated/v2.0/petstore.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export interface FullRequestParams extends Omit<RequestInit, "body"> {
/** query params */
query?: QueryParamsType;
/** format of response (i.e. response.json() -> format: "json") */
format?: keyof Omit<Body, "body" | "bodyUsed">;
format?: ResponseFormat;
/** request body */
body?: unknown;
/** base url */
Expand Down
2 changes: 1 addition & 1 deletion tests/generated/v2.0/query-path-param.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export interface FullRequestParams extends Omit<RequestInit, "body"> {
/** query params */
query?: QueryParamsType;
/** format of response (i.e. response.json() -> format: "json") */
format?: keyof Omit<Body, "body" | "bodyUsed">;
format?: ResponseFormat;
/** request body */
body?: unknown;
/** base url */
Expand Down
2 changes: 1 addition & 1 deletion tests/generated/v2.0/uber.ts
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ export interface FullRequestParams extends Omit<RequestInit, "body"> {
/** query params */
query?: QueryParamsType;
/** format of response (i.e. response.json() -> format: "json") */
format?: keyof Omit<Body, "body" | "bodyUsed">;
format?: ResponseFormat;
/** request body */
body?: unknown;
/** base url */
Expand Down
2 changes: 1 addition & 1 deletion tests/generated/v3.0/additional-properties.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export interface FullRequestParams extends Omit<RequestInit, "body"> {
/** query params */
query?: QueryParamsType;
/** format of response (i.e. response.json() -> format: "json") */
format?: keyof Omit<Body, "body" | "bodyUsed">;
format?: ResponseFormat;
/** request body */
body?: unknown;
/** base url */
Expand Down
2 changes: 1 addition & 1 deletion tests/generated/v3.0/additional-properties2.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export interface FullRequestParams extends Omit<RequestInit, "body"> {
/** query params */
query?: QueryParamsType;
/** format of response (i.e. response.json() -> format: "json") */
format?: keyof Omit<Body, "body" | "bodyUsed">;
format?: ResponseFormat;
/** request body */
body?: unknown;
/** base url */
Expand Down
2 changes: 1 addition & 1 deletion tests/generated/v3.0/allof-example.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export interface FullRequestParams extends Omit<RequestInit, "body"> {
/** query params */
query?: QueryParamsType;
/** format of response (i.e. response.json() -> format: "json") */
format?: keyof Omit<Body, "body" | "bodyUsed">;
format?: ResponseFormat;
/** request body */
body?: unknown;
/** base url */
Expand Down
2 changes: 1 addition & 1 deletion tests/generated/v3.0/anyof-example.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export interface FullRequestParams extends Omit<RequestInit, "body"> {
/** query params */
query?: QueryParamsType;
/** format of response (i.e. response.json() -> format: "json") */
format?: keyof Omit<Body, "body" | "bodyUsed">;
format?: ResponseFormat;
/** request body */
body?: unknown;
/** base url */
Expand Down
2 changes: 1 addition & 1 deletion tests/generated/v3.0/api-with-examples.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export interface FullRequestParams extends Omit<RequestInit, "body"> {
/** query params */
query?: QueryParamsType;
/** format of response (i.e. response.json() -> format: "json") */
format?: keyof Omit<Body, "body" | "bodyUsed">;
format?: ResponseFormat;
/** request body */
body?: unknown;
/** base url */
Expand Down
2 changes: 1 addition & 1 deletion tests/generated/v3.0/callback-example.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export interface FullRequestParams extends Omit<RequestInit, "body"> {
/** query params */
query?: QueryParamsType;
/** format of response (i.e. response.json() -> format: "json") */
format?: keyof Omit<Body, "body" | "bodyUsed">;
format?: ResponseFormat;
/** request body */
body?: unknown;
/** base url */
Expand Down
2 changes: 1 addition & 1 deletion tests/generated/v3.0/components-responses.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export interface FullRequestParams extends Omit<RequestInit, "body"> {
/** query params */
query?: QueryParamsType;
/** format of response (i.e. response.json() -> format: "json") */
format?: keyof Omit<Body, "body" | "bodyUsed">;
format?: ResponseFormat;
/** request body */
body?: unknown;
/** base url */
Expand Down
2 changes: 1 addition & 1 deletion tests/generated/v3.0/explode-param-3.0.1.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export interface FullRequestParams extends Omit<RequestInit, "body"> {
/** query params */
query?: QueryParamsType;
/** format of response (i.e. response.json() -> format: "json") */
format?: keyof Omit<Body, "body" | "bodyUsed">;
format?: ResponseFormat;
/** request body */
body?: unknown;
/** base url */
Expand Down
2 changes: 1 addition & 1 deletion tests/generated/v3.0/full-swagger-scheme.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8966,7 +8966,7 @@ export interface FullRequestParams extends Omit<RequestInit, "body"> {
/** query params */
query?: QueryParamsType;
/** format of response (i.e. response.json() -> format: "json") */
format?: keyof Omit<Body, "body" | "bodyUsed">;
format?: ResponseFormat;
/** request body */
body?: unknown;
/** base url */
Expand Down
2 changes: 1 addition & 1 deletion tests/generated/v3.0/link-example.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export interface FullRequestParams extends Omit<RequestInit, "body"> {
/** query params */
query?: QueryParamsType;
/** format of response (i.e. response.json() -> format: "json") */
format?: keyof Omit<Body, "body" | "bodyUsed">;
format?: ResponseFormat;
/** request body */
body?: unknown;
/** base url */
Expand Down
Loading