Release 5.0.0 #149
Merged
Release 5.0.0 #149
+17,479
−11,132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge content kind; feat: request content type auto substitution
… response body type ('any' -> 'void')
This was
linked to
issues
Feb 12, 2021
Closed
Styn
reviewed
Feb 15, 2021
| then<TResult1 = ResolveType, TResult2 = never>(onfulfilled?: ((value: ResolveType) => TResult1 | PromiseLike<TResult1>) | undefined | null, onrejected?: ((reason: RejectType) => TResult2 | PromiseLike<TResult2>) | undefined | null): TPromise<TResult1 | TResult2, RejectType>; | ||
| catch<TResult = never>(onrejected?: ((reason: RejectType) => TResult | PromiseLike<TResult>) | undefined | null): TPromise<ResolveType | TResult, RejectType>; | ||
| } | ||
| <% } %> | ||
|
|
||
| export interface HttpResponse<D extends unknown, E extends unknown = unknown> extends Response { |
There was a problem hiding this comment.
This makes it hard to type responses in code that uses the HttpClient.
(For example when using this with the call method of redux-saga where you need to type the expected response yourself, since call uses any.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
i.e. if request body is form data, then request body content type will be
multipart/form-data:paramNamepath params (issue Critical bug with:paramNamepath params #154)Features:
fetchresponse"IMAGE"content kind for response\request data objectsRequestParamsRequestHeaderstypes for--route-types(routeTypes: true) option (issue Route parameter types #150, thanks @Fabiencdp )--default-responseoption. Allows to set default type for empty response schema (default:void) (based on issue Default response body type. #14)RequestParamstype now have thecancelTokenfieldHttpClientinstance now have theabortRequest(cancelToken)methodBREAKING_CHANGES:
http-client.etatemplate, make it more flexible and simpler.HttpClient["request"]takes one argument with typeFullRequestParams(previously it takes many count of arguments which was not flexible)
anytovoid(issue Default response body type. #14)Internal:
http-client.etaprocedure-call.etaapi.etaThis version works with previous templates.