Merge pull request #71 from absurdprofit/development

Refactor to avoid persisting config to history state.
absurdprofit · Sep 7, 2024 · e8b3d37 · e8b3d37
2 parents 9287a3b + 658be67
commit e8b3d37
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/packages/stack/src/Screen.tsx b/packages/stack/src/Screen.tsx
@@ -56,7 +56,10 @@ export class Screen extends ScreenBase<ScreenProps, ScreenState, RouteProp> {
 
     protected setConfig(newConfig: NonNullable<ScreenProps["config"]>): void {
         super.setConfig(newConfig);
-        this.setHistoryState(({ config }) => ({ config: { ...config, ...newConfig } }));
+        // navigation history state can only accept structured cloneable objects.
+        // a lot of the config options are function which cannot be structured cloned.
+        // for this reason remove this for now unless a good argument is made for persisting config to history state.
+        // this.setHistoryState(({ config }) => ({ config: { ...config, ...newConfig } }));
     }
 
     protected get router() {