feat(updater): add Gradle support #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! I’ll take a look over the weekend |
|
Thanks for this! Apologies for taking so long to get to it. This is nice work. I'm a little nervous about whether the version regex will work for all gradle files, but since it will work for the majority of cases, and I can't see any pathological failures, I'm inclined to bring this in and correct it later if there are problems. If you have a moment to contribute a test for the Groovy case too, that would be awesome. I don't want to block the release though, so I'll merge this and get it out now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple change to bring Gradle (both Groovy and Kotlin DSL format will work) support by adding the corresponding updater.