V12.2.5 PR14.7 #5

CryptoCentric · 2019-02-26T12:36:22Z

Continuation of Backports PR14

…top of bitcoin#9196) 1126c85 [qa] Change sync_blocks to pick smarter maxheight (Russell Yanofsky)

d2b88f9 Move orphan-conflict removal from main logic into a callback (Matt Corallo) 97e2802 Erase orphans per-transaction instead of per-block (Matt Corallo) ec4525c Move orphan processing to ActivateBestChain (Matt Corallo)

… text e3c4f7e Correct help output for waitfor RPC commands (fanquake)

f26da35 Fix copypasted comment. (Pavel Janík)

5262a15 tx_valid: re-order inputs to how they are encoded (Daniel Cousens)

……tx). 2f2625a Removed using namespace std from bitcoin-cli/-tx and added std:: in appropriate places. (Karl-Johan Alm)

c7be56d net: push only raw data into CConnman (Cory Fields) 2ec935d net: add CVectorWriter and CNetMsgMaker (Cory Fields) b7695c2 net: No need to check individually for disconnection anymore (Cory Fields) fedea8a net: don't send any messages before handshake or after requested disconnect (Cory Fields) d74e352 net: Set feelers to disconnect at the end of the version message (Cory Fields)

…ux subsystem dd34570 doc: Improve windows build instructions using Linux subsystem (Wladimir J. van der Laan)

15fa95d Fix some typos (fsb4000)

498a1d7 Include select.h when WIN32 is not defined (Ivo van der Sangen)

dfed983 Fix unlocked access to vNodes.size() (Matt Corallo) 3033522 Remove double brackets in addrman (Matt Corallo) dbfaade Fix AddrMan locking (Matt Corallo) 047ea10 Make fImporting an std::atomic (Matt Corallo) 42071ca Make fDisconnect an std::atomic (Matt Corallo)

3532818 bench: Add support for measuring CPU cycles (Wladimir J. van der Laan)

… after datadir lock errors deec83f init: Get rid of fServer flag (Wladimir J. van der Laan) 16ca0bf init: Try to aquire datadir lock before and after daemonization (Wladimir J. van der Laan) 0cc8b6b init: Split up AppInit2 into multiple phases (Wladimir J. va

Needed by CMasternodePing

…tion declarations 446a8f9 Trivial refactor: Remove extern keyword from function declarations, as they are extern by default. (Karl-Johan Alm)

bdb922b Remove pnodeLocalHost. (Gregory Maxwell) 083f203 Remove fNetworkNode. (Gregory Maxwell)

8b22efb Make fStartedNewLine an std::atomic_bool (Matt Corallo) 507145d Fix race when accessing std::locale::classic() (Matt Corallo)

9e1f468 Fix calculation of number of bound sockets to use (Matt Corallo)

10ae7a7 Revert "Use async name resolving to improve net thread responsiveness" (Matt Corallo)

e878689 Make GUI incapable of setting tx confirm target of 1 (Alex Morcos) d824ad0 Disable fee estimates for a confirm target of 1 block (Alex Morcos)

fe37fbe bitcoin-cli: Make error message less confusing (Wladimir J. van der Laan)

b7aa290 unification of Bloom filter representation (S. Matthew English)

08ed8c1 Developer docs about existing subtrees. (Gregory Maxwell)

0828619 [qa] Dump debug logs on travis failures. (Suhas Daftuar)

facbfa5 [qa] Get rid of duplicate code (MarcoFalke) master (dashpay#1856) v0.13.1.0

…meter 'whitelist' 8a70a9d Improvement of documentation of command line parameter 'whitelist' (wodry)

81e3228 Make CTransaction actually immutable (Pieter Wuille) 42fd8de Make DecodeHexTx return a CMutableTransaction (Pieter Wuille) c3f5673 Make CWalletTx store a CTransactionRef instead of inheriting (Pieter Wuille) a188353 Switch GetTransaction to returning a CTransactionRef (Pieter Wuille)

Lost while backporting bitcoin#9183

Instead of deriving from CTransaction, we now have a CTransactionRef member in CTxLockCandidate. This is needed for the next backported PR bitcoin#8580, which will make CTransaction immutable. Also use CTransactionRef in CDarkSendEntry, CDarksendBroadcastTx and CPrivateSendServer

30b620c remove obsolete run-bitcoind-for-test.sh (Alex Morcos) 2a99522 remove relaypriority from rpc tests (Alex Morcos) e2184cc Reorder RPC tests for running time (Alex Morcos)

…tion This was missed in dashpay#1857. ConnectNode is doing the initial AddRef for outgoing connections. AcceptConnection also has to do an initial AddRef call for incoming connections.

ConnectNode is meant to be private and should not be leaked outside of CConnman. This leaking resulted in multiple problems with AddRef/Release behaviour. We use OpenNetworkConnectio/OpenMasternodeConnection from now on and use appropriate ForNode calls to access the CNode* instance. This commit also changes the behaviour for already connected nodes which are afterwards requested for a masternode connection. We don't set fMasternode=true anymore on such nodes, which means it won't be auto disconnected anymore from ProcessMasternodeConnections.

…nectNode

…/Absolute-Combine into v12.2.5PR14.7

Absification of ONLY_MN_COLLATERAL after backports

CTransactionRef changes require header to be updated to suit premine disablement validation

This reverts commit c3fa9ab.

This reverts commit 4838d42.

This reverts commit 4dfa918.

Issues with bitcoin#8580, bitcoin#9296, and dash commits 4838d42 0d3a429 This must be fixed at a later date

V12.2.5 PR14.7.1

CryptoCentric · 2019-02-26T12:36:33Z

Issues with bitcoin#8580, bitcoin#9296, and dash commits 4838d42
0d3a429

This must be fixed at a later date

MarcoFalke and others added 30 commits February 25, 2019 11:02

Merge bitcoin#9139: Change sync_blocks to pick smarter maxheight (on …

8baadb1

…top of bitcoin#9196) 1126c85 [qa] Change sync_blocks to pick smarter maxheight (Russell Yanofsky)

Merge bitcoin#9144: [Trivial] Correct waitforblockheight example help…

55a3743

… text e3c4f7e Correct help output for waitfor RPC commands (fanquake)

Merge bitcoin#9216: Doc: Fix copypasted comment

02bc70b

f26da35 Fix copypasted comment. (Pavel Janík)

Merge bitcoin#9100: tx_valid: re-order inputs to how they are encoded

5946bc0

5262a15 tx_valid: re-order inputs to how they are encoded (Daniel Cousens)

Merge bitcoin#9220: Refactor: Stop using namespace std (bitcoin-cli/-…

92a8b0e

……tx). 2f2625a Removed using namespace std from bitcoin-cli/-tx and added std:: in appropriate places. (Karl-Johan Alm)

Merge bitcoin#9219: doc: Improve windows build instructions using Lin…

10eaae9

…ux subsystem dd34570 doc: Improve windows build instructions using Linux subsystem (Wladimir J. van der Laan)

Merge bitcoin#9233: Fix some typos

c35470b

15fa95d Fix some typos (fsb4000)

Merge bitcoin#9224: Prevent FD_SETSIZE error building on OpenBSD

67cfbdf

498a1d7 Include select.h when WIN32 is not defined (Ivo van der Sangen)

Merge bitcoin#9202: bench: Add support for measuring CPU cycles

5de4e1c

3532818 bench: Add support for measuring CPU cycles (Wladimir J. van der Laan)

Add size() method to CVectorWriter

4a72ae9

Needed by CMasternodePing

Merge bitcoin#9244: Trivial refactor: Remove extern keyword from func…

f4522c0

…tion declarations 446a8f9 Trivial refactor: Remove extern keyword from function declarations, as they are extern by default. (Karl-Johan Alm)

Merge bitcoin#9226: Remove fNetworkNode and pnodeLocalHost.

43363f5

bdb922b Remove pnodeLocalHost. (Gregory Maxwell) 083f203 Remove fNetworkNode. (Gregory Maxwell)

Merge bitcoin#9230: Fix some benign races in timestamp logging

1d0226f

8b22efb Make fStartedNewLine an std::atomic_bool (Matt Corallo) 507145d Fix race when accessing std::locale::classic() (Matt Corallo)

Merge bitcoin#9253: Fix calculation of number of bound sockets to use

9a09584

9e1f468 Fix calculation of number of bound sockets to use (Matt Corallo)

Merge bitcoin#9229: Remove calls to getaddrinfo_a

bd538f4

10ae7a7 Revert "Use async name resolving to improve net thread responsiveness" (Matt Corallo)

Merge bitcoin#9239: Disable fee estimates for 1 block target

7b08f1f

e878689 Make GUI incapable of setting tx confirm target of 1 (Alex Morcos) d824ad0 Disable fee estimates for a confirm target of 1 block (Alex Morcos)

Merge bitcoin#9265: bitcoin-cli: Make error message less confusing

9124cf7

fe37fbe bitcoin-cli: Make error message less confusing (Wladimir J. van der Laan)

Merge bitcoin#9223: unification of Bloom filter representation

88b08f2

b7aa290 unification of Bloom filter representation (S. Matthew English)

Remove fNetworkNode

1e54bee

Merge bitcoin#9246: Developer docs about existing subtrees.

33cf443

08ed8c1 Developer docs about existing subtrees. (Gregory Maxwell)

Merge bitcoin#9257: [qa] Dump debug logs on travis failures.

fbe98ac

0828619 [qa] Dump debug logs on travis failures. (Suhas Daftuar)

Merge bitcoin#9221: [qa] Get rid of duplicate code

20e609b

facbfa5 [qa] Get rid of duplicate code (MarcoFalke) master (dashpay#1856) v0.13.1.0

Merge bitcoin#9251: Improvement of documentation of command line para…

e42e519

…meter 'whitelist' 8a70a9d Improvement of documentation of command line parameter 'whitelist' (wodry)

Add missing comments to ProcessNewBlock and ProcessNewBlockHeaders

62397a9

Lost while backporting bitcoin#9183

codablock and others added 26 commits February 25, 2019 18:07

Merge bitcoin#9276: Some minor testing cleanups

9caf30b

30b620c remove obsolete run-bitcoind-for-test.sh (Alex Morcos) 2a99522 remove relaypriority from rpc tests (Alex Morcos) e2184cc Reorder RPC tests for running time (Alex Morcos)

Absification part of developer-notes.md

df34fcf

Absification of Windows Build

dfbaf13

Use EXIT_FAILURE when calling exit()

b7bd2bb

Do not add to vNodes until fOneShot/fFeeler/fAddNode have been set

cc67333

Remove comment about masternode connections

e578a7a

Remove AddRef call in CNode constructor and do AddRef in AcceptConnec…

8b1fb60

…tion This was missed in dashpay#1857. ConnectNode is doing the initial AddRef for outgoing connections. AcceptConnection also has to do an initial AddRef call for incoming connections.

Absification of TX and utildial

84b0d91

Update invaild and valid Json

c8a30fc

remove use random nonce

3730163

Use OpenNetworkConnection instead of calling ConnectNode directly Con…

7fffa8f

…nectNode

Merge branch 'v12.2.5PR14.7' of https://github.com/absolute-community…

6cb6bc0

…/Absolute-Combine into v12.2.5PR14.7

Remove Version Headers (dashpay#1857)

73ff311

MNVERIFY Fix

0c4a6e4

Redefine ONLY_MN_COLLATERAL

255ace5

Absification of ONLY_MN_COLLATERAL after backports

Readjust Premine transaction to suit bitcoin#8580 Backports

8eba182

CTransactionRef changes require header to be updated to suit premine disablement validation

tx postion fix on MASTERNODE_COLLATERAL

f3c1fd7

CTransactionRef to CTransaction

c3fa9ab

Revert "CTransactionRef to CTransaction"

e08578b

This reverts commit c3fa9ab.

Revert "Preparations for upcoming backport of Bitcoin bitcoin#8580"

93ec6e1

This reverts commit 4838d42.

Revert "Merge bitcoin#8580: Make CTransaction actually immutable"

989963b

This reverts commit 4dfa918.

Reformat line spacing after website Ref

451e3cf

Revert bitcoin#9296: Fix missed change to WalletTx structure

04753da

revert tx changes until premine is adapted to suit

a2a6a6d

Issues with bitcoin#8580, bitcoin#9296, and dash commits 4838d42 0d3a429 This must be fixed at a later date

Merge pull request #4 from absolute-community/v12.2.5PR14.7.1

86b6d40

V12.2.5 PR14.7.1

CryptoCentric merged commit 1a5e152 into master Feb 26, 2019

CryptoCentric deleted the v12.2.5PR14.7 branch February 26, 2019 12:37

CryptoCentric restored the v12.2.5PR14.7 branch March 4, 2019 20:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

V12.2.5 PR14.7 #5

V12.2.5 PR14.7 #5

Uh oh!

CryptoCentric commented Feb 26, 2019

Uh oh!

CryptoCentric commented Feb 26, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

V12.2.5 PR14.7 #5

V12.2.5 PR14.7 #5

Uh oh!

Conversation

CryptoCentric commented Feb 26, 2019

Uh oh!

CryptoCentric commented Feb 26, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants