SMQ-2804 - Move Callouts from Auth Service to pkg/authz
#2823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2823 +/- ##
==========================================
+ Coverage 27.52% 27.56% +0.03%
==========================================
Files 351 214 -137
Lines 55423 44561 -10862
==========================================
- Hits 15257 12283 -2974
+ Misses 39415 31686 -7729
+ Partials 751 592 -159 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
arvindh123
reviewed
Apr 15, 2025
pkg/authz/authsvc/callback.go
Outdated
| @@ -125,3 +124,37 @@ func (c *callback) makeRequest(ctx context.Context, urlStr string, params map[st | |||
|
|
|||
| return nil | |||
| } | |||
|
|
|||
| func LoadCerts(authCalloutTLSVerification bool, authCalloutCert, authCalloutKey, authCalloutCACert string, authCalloutTimeout time.Duration) (*http.Client, error) { | |||
There was a problem hiding this comment.
We can have name like NewCalloutClient
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a refactor because it changes the following functionality:
pkg/authzWhat does this do?
pkg/authz.Which issue(s) does this PR fix/relate to?
pkg/authz#2804pkg/authz#2804Have you included tests for your changes?
Yes
Did you document any new/modified feature?
No
Notes