Skip to content

SMQ-2761 - Add route field to channels #2772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

felixgateru
Copy link
Contributor

@felixgateru felixgateru commented Mar 25, 2025

What type of PR is this?

This is a feature as it adds a route field to channels.

What does this do?

  • Introduces route attribute for channels
  • Updates relevent repository, service and api methods for this addition
  • Updates documentation and tests

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Yes, tests have been added for my changes.

Did you document any new/modified feature?

Yes, api documentation has been updated for the change

Notes

@felixgateru felixgateru requested a review from a team as a code owner March 25, 2025 14:29
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 41.74757% with 60 lines in your changes missing coverage. Please review.

Project coverage is 31.11%. Comparing base (62f4599) to head (4967efe).

Files with missing lines Patch % Lines
channels/mocks/repository.go 0.00% 34 Missing ⚠️
channels/postgres/channels.go 66.66% 11 Missing and 2 partials ⚠️
channels/events/events.go 0.00% 7 Missing ⚠️
channels/api/http/requests.go 50.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2772      +/-   ##
==========================================
+ Coverage   27.52%   31.11%   +3.58%     
==========================================
  Files         351       65     -286     
  Lines       55423    15281   -40142     
==========================================
- Hits        15257     4755   -10502     
+ Misses      39415    10273   -29142     
+ Partials      751      253     -498     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@felixgateru felixgateru changed the title SMQ-2761 - Add topic field to channels SMQ-2761 - Add route field to channels Mar 28, 2025
Copy link
Collaborator

@dborovcanin dborovcanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@felixgateru Please rebase.

@felixgateru felixgateru force-pushed the smq2761-topics branch 6 times, most recently from 1900dbf to 0aedef8 Compare April 8, 2025 12:01
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add topic field to channels
2 participants