SMQ-2632 - Separate PAT logic in middleware #2636
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyagamunene
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2636 +/- ##
==========================================
- Coverage 42.32% 34.40% -7.93%
==========================================
Files 350 243 -107
Lines 47867 40108 -7759
==========================================
- Hits 20259 13798 -6461
+ Misses 25402 25219 -183
+ Partials 2206 1091 -1115 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@arvindh123 Please review this one. |
dborovcanin
requested changes
Jan 11, 2025
nyagamunene
changed the title
nyagamunene
force-pushed
the
MG-2632
branch
2 times, most recently
from
8eb9581 to
4ae49e8
Compare
nyagamunene
force-pushed
the
MG-2632
branch
3 times, most recently
from
3d4f6e6 to
816a0e3
Compare
arvindh123
requested changes
Feb 13, 2025
nyagamunene
force-pushed
the
MG-2632
branch
2 times, most recently
from
acf54d5 to
e1f6026
Compare
dborovcanin
requested changes
Mar 4, 2025
There was a problem hiding this comment.
@nyagamunene What's the status with this one? Please rebase it.
@dborovcanin This is ready I have rebased it. |
felixgateru
requested changes
Mar 6, 2025
clients/middleware/authorization.go
Outdated
Comment on lines
104
to
105
| if err := am.checkSuperAdmin(ctx, session.UserID); err != nil { | ||
| return clients.ClientsPage{}, err |
There was a problem hiding this comment.
Please revert the logic here, superadmins and non superadmins can list clients, just set the SuperAdmin boolean
cmd/channels/main.go
Outdated
| @@ -195,6 +196,15 @@ func main() { | |||
| defer authzClient.Close() | |||
| logger.Info("AuthZ successfully connected to auth gRPC server " + authzClient.Secure()) | |||
|
|
|||
| pat, patHandler, err := authsvcPat.NewAuthorization(ctx, grpcCfg) | |||
| if err != nil { | |||
| logger.Error("failed to create authz " + err.Error()) | |||
There was a problem hiding this comment.
could you make this more decriptive to pats authz
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a refactor because it seperates PATs logic from Authz middleware
What does this do?
It seperates PATs logic from Authz middleware for users and clients
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Yes
Did you document any new/modified feature?
No
Notes