Fix type resolution by recursing prototypes #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzlsakal
reviewed
Aug 2, 2024
|
I just realized that the fixed test is broken with Done: ✅ |
jeffutter
force-pushed
the
recurse-prototype-type-resolution
branch
from
77e70e2
to
60290b0
Compare
kzlsakal
approved these changes
Aug 5, 2024
japhib
approved these changes
Aug 5, 2024
|
Huh I'm surprised the CI isn't running on this. Will review |
Did the main branch change from |
This fixes an issue when you have types declared in a Prototype (such as input_object input types for a directive). Previously type resolution would look on the Schema, but not the Prototype for the type definitions. You _could_ workaround this by duplicating your type definition into both the Schema and the Prototype. This makes me somewhat curious if there is a better way to fix this, in that the code that was trying to resolve the type here shouldn't be resolving it on the Schema, but rather on the Prototype 🤷. This seems to work though. Fixes absinthe-graphql#1279
jeffutter
force-pushed
the
recurse-prototype-type-resolution
branch
from
1f8122e
to
fad950d
Compare
|
I rebased this off the latest |
benwilson512
approved these changes
Aug 20, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue when you have types declared in a Prototype (such as input_object input types for a directive). Previously type resolution would look on the Schema, but not the Prototype for the type definitions.
You could workaround this by duplicating your type definition into both the Schema and the Prototype. This makes me somewhat curious if there is a better way to fix this, in that the code that was trying to resolve the type here shouldn't be resolving it on the Schema, but rather on the Prototype 🤷. This seems to work though.
Fixes #1279
Also should fix the issue mentioned here: DivvyPayHQ/absinthe_federation#81