Improve typechecks on nested args #1290
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds check to see if the variable type matches the argument type for nested arguments. Currently this check works only for "top level" arguments, but misses the ones used inside input objects (see the test case in PR).
Specifically, documents of the form:
where the variable
$value
is used inside of an input object literal were not checked properly prior to this PR.This is a bugfix, but will have the effect that some previously valid documents are now marked as invalid.