Skip to content

[GLOOP] Update SwitchUser and SwitchGroup to take absl::string_view #1090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Draft

[GLOOP] Update SwitchUser and SwitchGroup to take absl::string_view #1090

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions gloop/base/init_google.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ static bool IsSetgidUser() {
// enough capabilities, request is ignored. Various logging messages
// are generated, and if information about username cannot be obtained,
// the program will abort with a fatal error.
static void SwitchUser(const std::string& username) {
static void SwitchUser(absl::string_view username) {
#if GOOGLE_ENABLE_SETUID
uid_t new_uid;
CHECK(LookupUIDByName(username, &new_uid))
Expand Down Expand Up @@ -294,7 +294,7 @@ static void SwitchUser(const std::string& username) {
// the current uid does not have enough capabilities, request is ignored.
// Various logging messages are generated, and if information about username
// cannot be obtained, the program will abort with a fatal error.
static void SwitchGroup(const std::string& groupname, const std::string& uid) {
static void SwitchGroup(absl::string_view groupname, absl::string_view uid) {
#if defined(GOOGLE_ENABLE_SETGID)
const int kMaxTries = 48;

Expand Down Expand Up @@ -340,7 +340,7 @@ static void SwitchGroup(const std::string& groupname, const std::string& uid) {

if (!uid.empty()) {
// initgroups gives access to user's supplementary groups.
PCHECK(initgroups(uid.c_str(), new_gid) == 0)
PCHECK(initgroups(std::string(uid).c_str(), new_gid) == 0)
<< "initgroups(" << uid << ", " << new_gid << ") failed";
} else {
// Restrict access to just the specified group.
Expand Down
Loading