Merge pull request #485 from manshreck/master

Export of internal doc changes to Abseil OSS:
abseil · Jul 25, 2024 · 73fa238 · 73fa238
2 parents 2712108 + 03c20f1
commit 73fa238
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/docs/cpp/guides/flags.md b/docs/cpp/guides/flags.md
@@ -394,6 +394,12 @@ Despite this flexibility, we recommend using only a single form:
 `--variable=value` for non-boolean flags, and `--variable/--novariable` for
 boolean flags. This consistency will make your code more readable.
 
+Note that all command line flags are first parsed by the shell, which adheres to
+the rules of [shell expansion][shell-expansions]. Specifically, quotes are
+removed before passing any tokens off to the Flags Library. Care should be taken
+to never use "smart" quotes in such command lines, as they will not parse
+correctly.
+
 For integer flag types (int32_t, int64_t, uint64_t, etc.), the following
 formats are accepted:
 
@@ -653,3 +659,4 @@ std::string AbslUnparseFlag(const MyFlagType& flag) {
 [friend-functions]: http://en.cppreference.com/w/cpp/language/friend
 [time-library]: time.md#time-durations
 [civiltime-library]: time.md#civil-times
+[shell-expansions]: https://www.gnu.org/software/bash/manual/html_node/Shell-Expansions.html
diff --git a/docs/cpp/quickstart-cmake.md b/docs/cpp/quickstart-cmake.md
@@ -140,7 +140,7 @@ Note that we include an Abseil header file using the `absl` prefix.
 Now, create a `CMakeLists.txt` file within your `examples` directory like the following:
 
 ```
-cmake_minimum_required(VERSION 3.10)
+cmake_minimum_required(VERSION 3.16)
 
 project(my_project)
 

diff --git a/docs/cpp/tools/cmake-installs.md b/docs/cpp/tools/cmake-installs.md
@@ -106,7 +106,7 @@ the one we used in the
 `find_package` to import Abseil's targets from our local `install` directory.
 
 ```
-cmake_minimum_required(VERSION 3.10)
+cmake_minimum_required(VERSION 3.16)
 
 project(my_project)