Conversation
…t_of_t was used in the actual library.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
I think this is worth fixing but I would prefer to use a different approach. Abseil already has an internal version of invoke_result_t: This change has gotten me to revisit our internal Invoker class. I am working on bringing it up to adapt the new INVOKE() behavior introduced in C++17, and will make |
|
Just to touch base with you, I have not lost track of this CL. My initial attempt to correct this involved improving our My second attempt will be to make In any event, I will ultimately replace all uses of |
Abseil isn't compatible with C++20 (yet). abseil/abseil-cpp#705
This PR removes absl::result_of_t when compiling for C++20. I did the dead-simplest thing: I just added
#ifguards everywhere it is used.Alternatives that spring to mind:
Something appears to be wrong with your .clang-format file. It doesn't appear to produce the same results as the formatting that is actually in these files.