absl::meta Fix test alignment conformance for VS 2017 >= 15.8 (fix #193) #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mizux
changed the title
This was referenced Oct 19, 2018
JonathanDCohen
suggested changes
Oct 22, 2018
Mizux
force-pushed
the
193
branch
2 times, most recently
from
a6dcfac
to
ee37333
Compare
|
Can we first Merge PR #197 so I can rebase this work on it and so will should see this error gone. (i.e. kind of Test Driven Development (i.e. here the test is just to try to build on windows using appveyor)) |
JonathanDCohen
approved these changes
Oct 24, 2018
Mizux
force-pushed
the
193
branch
2 times, most recently
from
0e14306
to
8b20f8a
Compare
|
Should be replaced by cl/218851993 |
|
This was replicated internally and will be propagated to GitHub on our next push, so I'm going to close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Fix for #193 concerning the alignment issue with VS 15.8
note: since I removed the other commits we loose the CI tests from #197 here....