Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "wide" list view #135

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Support "wide" list view #135

merged 1 commit into from
Aug 22, 2024

Conversation

drelbszoomer
Copy link
Contributor

I frequently find myself needing to see at a glance what node a pod resides on.

This PR simply adds kubel-list-wide - if non-nil, list view uses -o wide kubectl option to display additional columns such as (in the case of pods) nodes, IPs, etc.

kubel.el Outdated Show resolved Hide resolved
@abrochard
Copy link
Owner

Thank you for submitting this! I'm wondering if there's a potential to make this a bit more generic and allow for user-defined arguments to be passed here instead of forcing -o wide?

@drelbszoomer
Copy link
Contributor Author

drelbszoomer commented Aug 21, 2024

Thank you for submitting this! I'm wondering if there's a potential to make this a bit more generic and allow for user-defined arguments to be passed here instead of forcing -o wide?

I considered that, but worried that might allow specifying options that break the list view rendering entirely, which is why I opted for just this.

Happy to do that tho, if you'd prefer.

@abrochard
Copy link
Owner

Thank you for submitting this! I'm wondering if there's a potential to make this a bit more generic and allow for user-defined arguments to be passed here instead of forcing -o wide?

I considered that, but worried that might allow specifying options that break the list view rendering entirely, which is why I opted for just this.

Happy to do that tho, if you'd prefer.

I reviewed the official doc and there are definitely some options that we could support in the future but I think it would make more sense as part of a larger feature work when we have more use cases.

Copy link
Owner

@abrochard abrochard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@abrochard abrochard merged commit e124c55 into abrochard:master Aug 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants