Provide kubel-kill-buffer command. #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since C-c C-k is fairly popular binding (magit, message, ...), provide it as well. It allows quickly canceling the edit without applying the changes. This also changes kubel-yaml-editing-mode to be defined using define-derived-mode from yaml-mode, with standalone map in kubel-yaml-editing-map. * kubel.el (kubel-kill-buffer-query): New custom. (kubel-kill-buffer): New function. (kubel-yaml-editing-map): New variable. (kubel-yaml-editing-mode): Change to derived-mode from minor-mode. (kubel--describe-resource, kubel-get-resource-details): Stop calling yaml-mode.
|
Uff, I made a mistake and you were too quick. Please see #136 . |
|
Really sorry about this. |
|
No worries! I should have caught it. Thank you for the follow up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since C-c C-k is fairly popular binding (magit, message, ...), provide it as well. It allows quickly canceling the edit without applying the changes.
This also changes kubel-yaml-editing-mode to be defined using define-derived-mode from yaml-mode, with standalone map in kubel-yaml-editing-map.
(kubel-kill-buffer): New function.
(kubel-yaml-editing-map): New variable.
(kubel-yaml-editing-mode): Change to derived-mode from minor-mode.
(kubel--describe-resource, kubel-get-resource-details): Stop calling yaml-mode.