Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Generate a filename that won't implicitely assume a subfolder #133

Merged
merged 1 commit into from
Aug 7, 2024
Merged

fix: Generate a filename that won't implicitely assume a subfolder #133

merged 1 commit into from
Aug 7, 2024

Conversation

Konubinix
Copy link
Contributor

Or the kubectl command will fail.

For EKR clusters, the buffer name contains a / character, leading to the need for this fix.

@Konubinix
fix: Generate a filename that won't implicitely assume a subfolder
69af4e7 
Or the kubectl command will fail.

For EKR clusters, the buffer name contains a / character, leading
to the need for this fix.
@Konubinix
Copy link
Contributor Author

The failing test has nothing to do with the current pull request. Right ?

@abrochard
Copy link
Owner

Thank you for submitting this!

The failing test has nothing to do with the current pull request. Right ?

Yeah I'm not sure what's happening. Emacs 26 might be EOL and breaking tests. You're good

@abrochard abrochard merged commit 68da30c into abrochard:master Aug 7, 2024
3 of 5 checks passed
@Konubinix
Copy link
Contributor Author

Konubinix commented Aug 7, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abrochard abrochard abrochard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Konubinix @abrochard