Remove kubectl version check #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed a check that verifies if the server version is greater than 1.13. As per the Kubernetes release documentation (https://kubernetes.io/releases/patch-releases/), version 1.13 has reached its end-of-life (EOL) status since 2019. Considering this information, I strongly believe that this check is unnecessary and can be safely removed. It's only used here: - https://github.com/abrochard/kubel/blob/a84f09cca8cdc71d55aa78304db4156df46d04e8/kubel.el#L896 Removing this check will not impact the functionality of the codebase, as it is only required for outdated Kubernetes versions that are more than four years old and no longer supported. It is highly unlikely that anyone would be using such an outdated version that cannot be found online for download. By removing this unnecessary code, we can eliminate technical debt and improve the overall readability and maintainability of the codebase. Thank you for considering this proposal.
abrochard
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a check that verifies if the server version is greater than 1.13. As per the Kubernetes release documentation (https://kubernetes.io/releases/patch-releases/), version 1.13 has reached its end-of-life (EOL) status since 2019. Considering this information, I strongly believe that this check is unnecessary and can be safely removed.
It's only used here:
kubel/kubel.el
Line 896 in a84f09c
Removing this check will not impact the functionality of the codebase, as it is only required for outdated Kubernetes versions that are more than four years old and no longer supported. It is highly unlikely that anyone would be using such an outdated version that cannot be found online for download.
By removing this unnecessary code, we can eliminate technical debt and improve the overall readability and maintainability of the codebase.
Thank you for considering this proposal.