Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: each pair of namespace-resource will be a buffer #112

Closed
wants to merge 1 commit into from

Conversation

TxGVNN
Copy link
Contributor

@TxGVNN TxGVNN commented Aug 30, 2023

Hi @abrochard,

Come back by few months, I have an KISS idea to resolve #96.
And I added kubel-switch-to-buffer to display only kubel buffers and switch from here.

By using local-var we can separate buffers for each pair of namespace-resouce. Perhaps we can consider context too.

So funny when creating this PR, I was looking back #57. Hi @d1egoaz, we have the same idea. But when I run on your code, it throws error so I can not test it.
If you have time, could you rebase on your PR, and we can contribute together to make it best. Because I'm not sure my PR is better than yours. What is your thought?

@TxGVNN
Copy link
Contributor Author

TxGVNN commented Aug 30, 2023

Updated:
s/define-transient-command/transient-define-prefix/ on #57, seems it works. Let me have a test

@d1egoaz
Copy link
Contributor

d1egoaz commented Aug 30, 2023

I've been very busy since last year and couldn't keep up with trying to contribute my fork.

This is my current fork, which I use every single day to connect to dozens of context/namespaces/resources at the same time: https://github.com/d1egoaz/kubel/tree/diego/multiple-kubel-buffers. The multi kubel buffer works for me, with each buffer having a different configuration of cluster/namespace/resource.

There are many changes on my branch (single process buffer, keymaps), and a lot of deleted code for things that I didn't care about (tramp, kubectl versions, etc). I hope someday I can rebase upstream and send a new PR again.

My usage:
kubel opens a new kubel buffer.
Then:
c to change context (with universal argument refresh contexts).
n to change namespace (with universal argument refresh namespaces).
r to change resource (with universal argument refresh resources).
x to call kubel-refresh and refresh current buffer.

I use only evil mode, not sure if my mapping changes without evil will work fine.

Let me know if it works for you @TxGVNN , I guess with more interest I can spend some cycles trying to bring back my branch.

@abrochard
Copy link
Owner

Hi yall, this is really cool!

I'm a bit swamped this week, but I will try to give it a review/test next week. And also see how the situation has evolved

@TxGVNN
Copy link
Contributor Author

TxGVNN commented Sep 7, 2023

I was thinking I had time but ... :D

Anyway, I see the core of #57 sound good. We can rebase and fix bugs, remove extra things (as evil key, evil can be other PR), add kubel-switch-to-buffer to switch only kubel's buffers.

@d1egoaz What do you think if I can take your PR and create new one from my view, then you and @abrochard can review

@d1egoaz
Copy link
Contributor

d1egoaz commented Sep 8, 2023

@d1egoaz What do you think if I can take your PR and create new one from my view, then you and @abrochard can review

For sure! go for it! My current branch (kubel) that I use have some more additional changes https://github.com/d1egoaz/kubel/tree/diego/multiple-kubel-buffers

@TxGVNN
Copy link
Contributor Author

TxGVNN commented Sep 11, 2023

Thank you, @d1egoaz.

I close this issue and reopen for a new one at #114. Could you guys take a look?

@TxGVNN TxGVNN closed this Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[discuss] How about sections?
3 participants