Make vterm option in kubel-exec-pod opt-in #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Upon further reflection I think that it doesn't make much sense to move it to a separate file, instead I'll move the require to the kubel-vterm-setup function. I'll update the PR. |
|
Thank you for submitting this. I'm not a vterm user and I was scratching my head last week when debugging this. I agree that moving to a separate file isn't required. But I like the other changes! |
In kubel-exec-vterm-pod: kubel.el:939:4: Warning: misplaced interactive spec: ‘(interactive)’
PuercoPop
force-pushed
the
extract-vterm
branch
from
9d5620e
to
7c889e6
Compare
PuercoPop
changed the title
|
@abrochard I've updated the PR with what I had in mind. Is this aligned with what you had in mind? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR has two commits, the first one is uncontroversial, the interactive spec should be the first form in the function (with the possible exception of the a declare form iiuc), so we need to swap places with the call to (require 'vterm).
The second commit is something that, although I prefer, I can understand if its rejected. I dislike require forms outside of top-level forms, so I extracted the vterm related function to a separate file. I use vterm myself so I've verified the transient has the option available with the steps in the README.md. Although using vterm from kubel hasn't working for me though but that is out of scope for this PR.
lmkwyt