Add conversation views to 7 chat artifacts (Tier 1 + WhatsApp, Viber, Kik) - #1645
Merged
Conversation
Wire the LAVA conversation data_view onto existing columns for Line
Artifacts, Oops: Make New Friends, Zangi Chats and Query Predictions.
directionSentValue verified against each query's literal output ('Outgoing'
for Line/Oops, 'SENT' for Zangi, integer 1 for queryPredictions' isSent).
Artifacts without a local-sender column use sentMessageStaticLabel.
Metadata-only; no parsing changes; last_update_date bumped.
ZISFROMME was already selected (used for sender/receiver) but never emitted; add a Direction column from it, plus Chat ID (ZWACHATSESSION.ZCONTACTJID, one new SELECT column on the existing join) and Chat Name (ZPARTNERNAME) as a stable thread discriminator/label. Conversation view wired with Sender Name (already 'Local User' on sent rows) and Attachment File as mediaColumn. New columns appended at the end so existing column order is unchanged.
abrignoni
changed the title
Validation runs across 11 test images showed both artifacts already emit a
usable direction column: Viber's State ('Incoming'/'Outgoing', 3,459 rows
verified) and Kik's Type ('Sent'/'Received'). Metadata-only views: Viber
threads by Chat Participant(s) with Chat Name label, Kik by User Name; both
wire their media-typed Attachment column as mediaColumn and use the static
'Local User' sent label.
abrignoni
changed the title
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the LAVA threaded
conversationdata_view to the 4 iLEAPP chat artifacts whose existing columns already support it (metadata-only, no parsing changes):Outgoing(from ZSENDER CASE)Outgoing(from message_direction CASE)SENT(uppercase, from ZISRECEIVED CASE)1(rawisSentinteger)Every
directionSentValueverified against the literal value each query produces.Deliberately deferred
ZDIRECTIONvalues not verifiable without test dataZangiChats.pyvsZangiMessenger.pymay be duplicate modules for the same app — possible future consolidationTesting
pylint 10.00/10 on all 4 files; PluginLoader 4/4 views registered; automated check validates every view column ref against each artifact's actual
data_headers.