Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw err when the second arguments is not a Number/String #2

Merged
merged 2 commits into from
Apr 26, 2019
Merged

Throw err when the second arguments is not a Number/String #2

merged 2 commits into from
Apr 26, 2019

Conversation

LeandroEstevez
Copy link
Contributor

@LeandroEstevez LeandroEstevez commented Apr 25, 2019

Throw err when the second arguments is not a Number/String

How it is now:

import m2r from 'minutes-to-read';

m2r('str', {} || []);

Nothing will happen

import m2r from 'minutes-to-read';

m2r('str', {} || []);

Now it will throw an error

Expected an String/Number in the second argument, got {something else}

@abranhe abranhe reopened this Apr 26, 2019
@abranhe abranhe changed the title fixed issue Throw err when the second arguments is not a Number/String Apr 26, 2019
@abranhe abranhe merged commit 7dda9fa into abranhe:master Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants